Allow deep indifferent access on Hanami::Utils::Attributes

[Erol]

Address hanami/controller#70 by making Hanami::Utils::Attribute#get return Hanami::Utils::Attributes for hash-like attribute values.

[coveralls]

Coverage increased (+0.0005%) to 98.203% when pulling f59b51a on Erol:allow-deep-indifferent-access into b5a7903 on hanami:master.

[runlevel5]

good one, can we test against the nested string syntax instead? eg: params.get('address.street')

[Erol]

Oh yeah, I forgot to test that one. New commit coming up.

[Erol]

How about this?

[coveralls]

Coverage increased (+0.002%) to 98.204% when pulling 3ba875c on Erol:allow-deep-indifferent-access into b5a7903 on hanami:master.

[coveralls]

Coverage increased (+0.002%) to 98.204% when pulling 99f6325 on Erol:allow-deep-indifferent-access into b5a7903 on hanami:master.

[runlevel5]

looks good, the test fails for other unrelated reason. Would you be able to have a look at that too?

[davydovanton]

What do you think, maybe is better to get only last key from split instead unnecessary enumeration? I. e.:

value = @attributes

key = attribute.to_s.split(?.).last
value = value[key] if value

[Erol]

We wouldn't be able to cover deep access with that, like for example:

attributes = Hanami::Utils::Attributes.new({address: {street: 'Street', city: 'City'}})
attributes.get("address.street")

[davydovanton]

yep, you're right!
Thanks for explanation! 👍

[Erol]

👍

[Erol]

@joneslee85: Can't reproduce the error on my local, but sure I'll also take a look at it.

[coveralls]

Coverage increased (+0.002%) to 98.204% when pulling 2bc5ce3 on Erol:allow-deep-indifferent-access into b5a7903 on hanami:master.

[Erol]

I squashed my commits and Travis already passed. Maybe a brittle test for file permissions?

[Erol]

Thanks for the merge!