Wrap rule errors by namespace

[DSIW]

I created a minimal example with the problem: https://gist.github.com/DSIW/d8bf6e71ce9fd7b952e74cf7fec9a123

I assume that the error rule time_range should be wrapped by the contract namespace like the vendor validation. What do you think?

[DSIW]

It works if I use a rule with the name of one of the required keys: ends_on

I think, the other way should work, too.

validations do
  required(:vendor)    { type?(String) & present? }
  required(:starts_on) { type?(String) & present? }
  required(:ends_on)   { type?(String) & present? }

  rule(ends_on: [:starts_on, :ends_on]) do |starts_on, ends_on|
    ends_on.gt?(starts_on)
  end
end

[AlfonsoUceda]

Hi @DSIW thanks for the issue and sorry for the trouble, I'll look as soon as possible ;)

[AlfonsoUceda]

@DSIW it seems a bug in dry-validations:

inner_schema = Dry::Validation.Schema do
  required(:vendor)    { type?(String) & filled? }
  required(:starts_on) { type?(String) & filled? }
  required(:ends_on)   { type?(String) & filled? }

  rule(time_range: [:starts_on, :ends_on]) do |starts_on, ends_on|
    ends_on.gt?(starts_on)
  end
end

schema = Dry::Validation.Schema do
  required(:contract).schema(inner_schema)
end

schema.call(contract: {vendor: '', starts_on: '2019-01-01', ends_on: '2018-01-01'}).messages
# => {:contract=>{:vendor=>["must be filled"]}, :time_range=>["must be greater than 2019-01-01"]}

inner_schema.call({vendor: '', starts_on: '2019-01-01', ends_on: '2018-01-01'}).messages
# => {:vendor=>["must be filled"], :time_range=>["must be greater than 2019-01-01"]}

I've asked in dry-rb gitter's chat to know if they can help us.

[jodosha]

Closing as stale conversation.