Make Hanami::View::Rendering::LayoutScope to inherit from Hanami::Utils::BasicObject
#160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Utils::BasicObject` instead from Ruby's `BasicObject`
… already implemented by its new superclass: `Hanami::Utils::BasicObject`
…ject inspection. NOTE: this isn't a breaking change `Hanami::View::Rendering::LayoutScope` still respond to `#inspect` and it still returns the same inspection string. The behavior now it's just split with the superclass, because `Utils::BasicObject` already implements logic to print class name and object ID.
AlfonsoUceda
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Make
Hanami::View::Rendering::LayoutScopeto inherit fromHanami::Utils::BasicObjectinstead from Ruby'sBasicObject.This ensures a better interoperability with latest
tiltchanges. See rtomayko/tilt#347Technical details
Hanami::View::Rendering::LayoutScope#is_a?is no longer implicitly dispatched to the internal@scopeas per effect of#method_missing. BecauseHanami::Utils::BasicObjectimplements#is_a?,#method_missingis no longer called. It's important forHanami::View::Rendering::LayoutScopeto take control on#is_a?because it led to unexpected behaviors likeis_a?(Module)to returntrue, because the current@scopewas aModule. Of courseHanami::View::Rendering::LayoutScopeisn't aModule, but a basic object, and#is_a?must reflect it.Hanami::View::Rendering::LayoutScope#classwas removed because it's already implemented by the new superclass:Hanami::Utils::BasicObject.The behavior of
#inspectis extracted into the private method#__inspect. This is aUtils::BasicObjecthook to allow its subclasses to define their own inspect logic.Hanami::View::Rendering::LayoutScopewill still continue to respond to#inspectand to return the same inspecting string. The implementation is now split between the new superclass and the layout scope itself.Gemfiletemporary points tohanami-utilsbranch that contains anotherUtils::BasicObjectfix that makeshanami-viewbuild to pass withtilt2.0.10. See LetUtils::BasicObjectto lookup constants at the top-level namespace utils#343