Add support for doctrine/annotations 2.0 and remove requirement to doctrine/cache #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-schranz
added
enhancement
alexander-schranz
force-pushed
the
enhancement/support-doctrine-annotations-2-0
branch
from
69e7c46
to
c5be651
Compare
| - php-version: '7.2' | ||
| elasticsearch-version: '5.6.14' | ||
| lint: false | ||
| symfony-version: '^2.8' |
There was a problem hiding this comment.
support for Symfony 2 dropped because of requirement to symfony/cache
alexander-schranz
force-pushed
the
enhancement/support-doctrine-annotations-2-0
branch
from
c5be651
to
f04b5c8
Compare
alexander-schranz
force-pushed
the
enhancement/support-doctrine-annotations-2-0
branch
from
f04b5c8
to
7167d69
Compare
Comment on lines
+32
to
+46
| $hasContainerBuildId = $container->hasParameter('container.build_id'); | ||
| if (!$hasContainerBuildId) { | ||
| // the 'container.build_id' is required for `es.cache_engine` system cache which normally can not | ||
| // be constructor inside a compiler pass. This is a workaround to make it work. | ||
| // see also: | ||
| // - https://github.com/symfony/symfony/blob/52a92926f7fed15cdff399c6921100a10e0d6f61/src/Symfony/Component/DependencyInjection/Dumper/PhpDumper.php#L389 | ||
| // - https://github.com/symfony/symfony/blob/52a92926f7fed15cdff399c6921100a10e0d6f61/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L2322 | ||
| $hasContainerBuildId = true; | ||
| $container->setParameter('container.build_id', hash('crc32', 'Abc123' . time())); | ||
| } | ||
|
|
||
| $collector = $container->get('es.metadata_collector'); | ||
| if (!$hasContainerBuildId) { | ||
| $container->getParameterBag()->remove('container.build_id'); | ||
| } |
There was a problem hiding this comment.
This is required when using the cache.system and access it inside the compile time. Another possibility would be to use the cache.app but which does not require build_id. But metadata normally is invalidated between deployments and should fast readable which normally is job of the cache.system and not the cache.app.
You have requested a non-existent parameter "container.build_id".
alexander-schranz
force-pushed
the
enhancement/support-doctrine-annotations-2-0
branch
from
aef3071
to
adeb229
Compare
Comment on lines
+99
to
+104
| - name: Composer require | ||
| if: ${{ matrix.symfony-version == '^4.4' }} | ||
| # symfony 4.4 not compatible with doctrine/annotations 2.0: https://github.com/symfony/symfony/issues/48717#issuecomment-1359164836 | ||
| run: | | ||
| composer require --no-update doctrine/annotations:^1.10 | ||
|
|
There was a problem hiding this comment.
Required for: Error: Call to undefined method Doctrine\Common\Annotations\AnnotationRegistry::registerLoader() in PHP 7.3 with Symfony 4.4
alexander-schranz
changed the title
alexander-schranz
force-pushed
the
enhancement/support-doctrine-annotations-2-0
branch
from
0b41a5f
to
7bc87fa
Compare
alexander-schranz
force-pushed
the
enhancement/support-doctrine-annotations-2-0
branch
from
7bc87fa
to
11de7a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
require atleast
1.13and updateCachedReaderto the withPSRCachedReader: doctrine/annotations@c66f06b.This requires that we move from doctrine/cache to symfony/cache psr cache think metadata can use the symfony system cache.
In this case i completely removed the requirement to
doctrine/cacheand replaced it in all cases with the PSRCacheReader. This is a small BC break which should mostly not have effects on existing systems. Still I would go here with a new Minor release so somebody could still require5.4.*when still want to use doctrine/cache or older annotations version.