Skip to content

Commit

Permalink
Test on Node 18 and drop EOL Node 10
Browse files Browse the repository at this point in the history
* Updated lock-file to fix npm/cli#4859.
* Updated integration-tests to webpack 5 to fix
  webpack/webpack#14532.
* Added `mode` to webpack-integration-tests to avoid
  the warning `The 'mode' option has not been set...`.
* Replaced outdated `grunt-bg-shell`-package to get rid of
  coffee-script warnings
  • Loading branch information
jaylinski committed Oct 16, 2022
1 parent 903ca50 commit 785a63e
Show file tree
Hide file tree
Showing 11 changed files with 843 additions and 3,420 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:
matrix:
operating-system: ['ubuntu-latest', 'windows-latest']
# https://nodejs.org/en/about/releases/
node-version: ['10', '12', '14', '16', '17']
node-version: ['12', '14', '16', '18']

steps:
- name: Checkout
Expand All @@ -78,8 +78,6 @@ jobs:
run: npm run test

- name: Test (Integration)
# https://github.com/webpack/webpack/issues/14532
if: ${{ matrix.node-version != '17' }}
run: |
cd ./tests/integration/rollup-test && ./test.sh && cd -
cd ./tests/integration/webpack-babel-test && ./test.sh && cd -
Expand Down
12 changes: 5 additions & 7 deletions Gruntfile.js
Original file line number Diff line number Diff line change
Expand Up @@ -111,11 +111,9 @@ module.exports = function(grunt) {
}
},

bgShell: {
shell: {
integrationTests: {
cmd: './tests/integration/run-integration-tests.sh',
bg: false,
fail: true
command: './tests/integration/run-integration-tests.sh'
}
},

Expand All @@ -139,7 +137,7 @@ module.exports = function(grunt) {
grunt.loadNpmTasks('grunt-contrib-uglify');
grunt.loadNpmTasks('grunt-contrib-watch');
grunt.loadNpmTasks('grunt-babel');
grunt.loadNpmTasks('grunt-bg-shell');
grunt.loadNpmTasks('grunt-shell');
grunt.loadNpmTasks('grunt-webpack');

grunt.task.loadTasks('tasks');
Expand All @@ -156,7 +154,7 @@ module.exports = function(grunt) {
// Requires secret properties from .travis.yaml
grunt.registerTask('extensive-tests-and-publish-to-aws', [
'default',
'bgShell:integrationTests',
'shell:integrationTests',
'metrics',
'publish-to-aws'
]);
Expand All @@ -176,6 +174,6 @@ module.exports = function(grunt) {
);
grunt.registerTask('integration-tests', [
'default',
'bgShell:integrationTests'
'shell:integrationTests'
]);
};
2 changes: 1 addition & 1 deletion README.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ Supported Environments

Handlebars has been designed to work in any ECMAScript 3 environment. This includes

- Node.js 10+
- Node.js 12+
- Chrome
- Firefox
- Safari 5+
Expand Down

0 comments on commit 785a63e

Please sign in to comment.