Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test failure caused by yargs #1213

Merged
merged 1 commit into from
May 17, 2016
Merged

Fix test failure caused by yargs #1213

merged 1 commit into from
May 17, 2016

Commits on Apr 21, 2016

  1. Fix test failure caused by yargs 

    In yargs 3.2, any non-truthy return value to check will fail: https://github.com/yargs/yargs/blob/master/CHANGELOG.md#302-20150213-1650-0000
It appears that this check is no longer necessary as the other contents of the check callback no longer exist: 2e7a3bd#diff-2aff13863648736946e83d70c5e63520L86
It appears the build failed for PR #1180, not sure why it was merged
    @jbboehr
    jbboehr committed Apr 21, 2016
    Configuration menu
    Copy the full SHA
    f0d4159 View commit details
    Browse the repository at this point in the history