Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context-stack when calling block-helpers on null values #1321

Merged
merged 1 commit into from
Mar 25, 2017
Merged

Commits on Mar 25, 2017

  1. Fix context-stack when calling block-helpers on null values

    Fixes #1319
    
    Original behaviour:
    - When a block-helper was called on a null-context, an empty object was used
      as context instead. (#1093)
    - The runtime verifies that whether the current context equals the
      last context and adds the current context to the stack, if it is not.
      This is done, so that inside a block-helper, the ".." path can be used
      to go back to the parent element.
    - If the helper is called on a "null" element, the context was added, even
      though it shouldn't be, because the "null != {}"
    
    Fix:
    - The commit replaces "null" by the identifiable "container.nullContext"
      instead of "{}". "nullContext" is a sealed empty object.
    - An additional check in the runtime verifies that the context is
      only added to the stack, if it is not the nullContext.
    
    Backwards compatibility within 4.0.x-versions:
    - This commit changes the compiler and compiled templates would not work
      with runtime-versions 4.0.0 - 4.0.6, because of the "nullContext"
      property. That's way, the compiled code reads
      "(container.nullContext || {})" so that the behavior will degrade
      gracefully with older runtime versions: Everything else will work
      fine, but GH-1319 will still be broken, if you use a newer compiler
      with a pre 4.0.7 runtime.
    nknapp committed Mar 25, 2017
    Configuration menu
    Copy the full SHA
    9c23e6a View commit details
    Browse the repository at this point in the history