Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP nested each with equal values #1686 #1687

Draft
wants to merge 2 commits into
base: 4.x
Choose a base branch
from
Draft

WIP nested each with equal values #1686 #1687

wants to merge 2 commits into from

Commits on May 5, 2020

  1. Add failing unit test for handlebars-lang#1686 

    Move test case into parent test suite "regressions".
    @graphicore
    graphicore committed May 5, 2020
    Configuration menu
    Copy the full SHA
    be8fe9f View commit details
    Browse the repository at this point in the history

  2. Add explicit goDeeper option to wraped program;Fixes handlebars-lang#… 

    …1686

According to the commit message of 279e038:

" [...] Helper authors now need to take care to return the same context
value whenever it is conceptually the same and to avoid behaviors that
may execute children under the current context in some situations and
under different contexts under other situations."

I belive that metric is too implicit, as the issue demonstrates. This
is because in this case the context value is not conceptually the same,
but it is de facto the same value.

Instead this suggests to use an explicit option flag "goDeeper" to mark
when a helper definitely should go deeper. This also should be backwards
safe, as it doesn't change the behavior of existing helpers, builtin or
custom, except the builtin "each",
    @graphicore
    graphicore committed May 5, 2020
    Configuration menu
    Copy the full SHA
    234cf2f View commit details
    Browse the repository at this point in the history