Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simply added double quote to partial not found error message ##1450 #1954

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

smmhatami
Copy link
Contributor

simply added double quote to partial not found error message :)

@jaylinski jaylinski self-assigned this Jun 28, 2023
Copy link
Member

@jaylinski jaylinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Can you fix the linting error (see CI pipeline) and the failing tests (see CI pipeline)?

@smmhatami smmhatami requested a review from jaylinski June 29, 2023 10:19
@jaylinski
Copy link
Member

Tests are still failing:


  1) partials
       failing dynamic partials:

      AssertionError: TemplateDudes: {{#dudes}}{{> (partial)}}{{/dudes}} does not evaluate to expected output: expected [Function] to throw error including 'The partial missing could not be found' but got 'The partial "missing" could not be found'
      + expected - actual

      -The partial "missing" could not be found
      +The partial missing could not be found
      
      at HandlebarsTestBench.toThrow (spec\env\common.js:214:14)
      at Context.<anonymous> (spec\partials.js:67:8)

  2) partials
       rendering undefined partial throws an exception:

      Template{{> whatever}} does not evaluate to expected output
      + expected - actual

      -The partial "whatever" could not be found
      +The partial whatever could not be found
      
      at HandlebarsTestBench.toThrow (spec\env\common.js:214:14)
      at Context.<anonymous> (spec\partials.js:157:38)

  3) partials
       rendering template partial in vm mode throws an exception:

      Template{{> whatever}} does not evaluate to expected output
      + expected - actual

      -The partial "whatever" could not be found
      +The partial whatever could not be found
      
      at HandlebarsTestBench.toThrow (spec\env\common.js:214:14)
      at Context.<anonymous> (spec\partials.js:175:38)

  4) partials
       inline partials
         should define inline partials for block:
     AssertionError: Template{{#with .}}{{#*inline "myPartial"}}success{{/inline}}{{/with}}{{> myPartial}} does not evaluate to expected output: expected [Function] to throw error matching /myPartial could not/ but got 'The partial "myPartial" could not be found'
      at HandlebarsTestBench.toThrow (spec\env\common.js:214:14)
      at Context.<anonymous> (spec\partials.js:475:9)

Can you fix them? If you don't know how, just let me know, I'll fix them myself.

@jaylinski jaylinski added this to the 5.0.0 milestone Aug 1, 2023
Signed-off-by: Seyed Mohammad Mahdi Hatami <hatamik7@gmail.com>
@jaylinski jaylinski merged commit 8ce2be4 into handlebars-lang:master Aug 31, 2023
14 checks passed
@jaylinski
Copy link
Member

Note: won't be backported to 4.x, because someone may rely on this specific error message not containing quotes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants