Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default is a reserved word #964

Merged
merged 1 commit into from
Feb 28, 2015
Merged

Conversation

grassick
Copy link
Contributor

default is a reserved word. Quoting it to fix in older browsers, especially Android 2.3.x. Otherwise, it throws exception on Android 2.3.6 at least.

Quoting it to fix in older browsers, especially Android 2.3.x.
@kpdecker
Copy link
Collaborator

I'll merge and release this as 3.0.1 when I get back from vacation. Leaving
open for now to serve as a reminder. Thanks for the PR!
On Wed, Feb 18, 2015 at 9:58 AM grassick notifications@github.com wrote:

default is a reserved word. Quoting it to fix in older browsers,
especially Android 2.3.x. Otherwise, it throws exception on Android 2.3.6

at least.

You can view, comment on, or merge this pull request online at:

#964
Commit Summary

  • default is a reserved word

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#964.

@kpdecker kpdecker added this to the 3.0.1 milestone Feb 28, 2015
@kpdecker kpdecker added the bug label Feb 28, 2015
kpdecker added a commit that referenced this pull request Feb 28, 2015
default is a reserved word
@kpdecker kpdecker merged commit 8c357b9 into handlebars-lang:master Feb 28, 2015
@grassick grassick deleted the patch-1 branch February 28, 2015 22:28
@radum
Copy link

radum commented Mar 5, 2015

This fixes IE8 also, lots of headaches with this one. I will buy you a 🍹 when 3.0.1 lands (soon I hope).

@kpdecker
Copy link
Collaborator

Released in 3.0.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants