Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HMM_LengthSquareRoot is poorly named #33

Closed
bvisness opened this issue Aug 29, 2016 · 4 comments
Closed

HMM_LengthSquareRoot is poorly named #33

bvisness opened this issue Aug 29, 2016 · 4 comments

Comments

@bvisness
Copy link
Member

This is not a bug, exactly, but when I was integrating Handmade Math into my project I was confused by the naming of HMM_LengthSquareRoot. I expected HMM_LengthSquared, or something, since the function actually produces the length of the vector squared. (No square root has happened yet!)
@StrangeZak
Copy link
Member

Oh! That should be changed then!

@bvisness
Copy link
Member Author

Changing the name has the potential to break projects though. Are we ok with that since we're still in early release, or would we want to mark it as deprecated somehow...? (I vote for just breaking things.)

@StrangeZak
Copy link
Member

Were pre 1.0 were fine to break things as long as put a notice in that we broke something

StrangeZak pushed a commit that referenced this issue Aug 30, 2016
Fixed issue #33, #32, #27, #30
712e5aa
@bvisness
Copy link
Member Author

Fixed in #37.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bvisness @StrangeZak