KOGITO-5894: Fix spotbugs issues (apache#106)

handreyrc · Oct 1, 2021 · f7ee360 · f7ee360
1 parent 2195dba
commit f7ee360
Show file tree

Hide file tree

Showing 10 changed files with 15 additions and 11 deletions.
diff --git a/...ulation/webapp/client/services/ScenarioSimulationKogitoRuntimeResourceContentService.java b/...ulation/webapp/client/services/ScenarioSimulationKogitoRuntimeResourceContentService.java
@@ -32,12 +32,11 @@ public void getFileContent(final Path path,
                                final RemoteCallback<String> remoteCallback,
                                final ErrorCallback<Object> errorCallback) {
         String result = vfsServiceFake.readAllString(path);
-        if(result == null && result.isEmpty()) {
+        if (result == null || result.isEmpty()) {
             String error = "Unable to open file: " + path;
             errorCallback.error(error, new Exception(error));
         } else {
             remoteCallback.callback(result);
         }
     }
-
 }
diff --git a/...-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/IOCBootstrapGenerator.java b/...-ioc/src/main/java/org/jboss/errai/ioc/rebind/ioc/bootstrapper/IOCBootstrapGenerator.java
@@ -322,7 +322,7 @@ public static void processExtensions(final GeneratorContext context,
   }
 
   @SuppressWarnings("rawtypes")
-  private static void maybeValidateDecorators(final MetaDataScanner scanner) {
+  private static synchronized void maybeValidateDecorators(final MetaDataScanner scanner) {
     if (decoratorMap == null || EnvUtil.isJUnitTest()) {
       decoratorMap = new HashMap<Class<? extends IOCDecoratorExtension>, Class<? extends Annotation>>();
       final Set<Class<?>> decorators = scanner.getTypesAnnotatedWith(CodeDecorator.class);

diff --git a/errai-ui/src/main/java/org/jboss/errai/ui/shared/wrapper/ElementWrapper.java b/errai-ui/src/main/java/org/jboss/errai/ui/shared/wrapper/ElementWrapper.java
@@ -16,6 +16,8 @@
 
 package org.jboss.errai.ui.shared.wrapper;
 
+import javax.annotation.Nullable;
+
 import org.w3c.dom.*;
 
 /**
@@ -65,11 +67,13 @@ public Attr removeAttributeNode(Attr oldAttr) throws DOMException {
   }
 
   @Override
+  @Nullable
   public NodeList getElementsByTagName(String name) {
     return null;
   }
 
   @Override
+  @Nullable
   public String getAttributeNS(String namespaceURI, String localName) throws DOMException {
     return null;
   }
@@ -93,6 +97,7 @@ public Attr setAttributeNodeNS(Attr newAttr) throws DOMException {
   }
 
   @Override
+  @Nullable
   public NodeList getElementsByTagNameNS(String namespaceURI, String localName) throws DOMException {
     return null;
   }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/AbstractImageShape.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/AbstractImageShape.java
@@ -123,7 +123,7 @@ public ImageSerializationMode getImageSerializationMode() {
     }
 
     public T setImageSerializationMode(final ImageSerializationMode serializationMode) {
-        this.imageSerializationMode = imageSerializationMode;
+        this.imageSerializationMode = serializationMode;
 
         return upcast();
     }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/IsoscelesTrapezoid.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/IsoscelesTrapezoid.java
@@ -184,7 +184,7 @@ public double getCornerRadius() {
     }
 
     public IsoscelesTrapezoid setCornerRadius(final double radius) {
-        this.cornerRadius = cornerRadius;
+        this.cornerRadius = radius;
 
         return refresh();
     }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/OrthogonalPolyLine.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/OrthogonalPolyLine.java
@@ -677,7 +677,7 @@ public double getCornerRadius() {
     }
 
     public OrthogonalPolyLine setCornerRadius(final double radius) {
-        this.cornerRadius = cornerRadius;
+        this.cornerRadius = radius;
 
         return refresh();
     }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/RegularPolygon.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/RegularPolygon.java
@@ -207,7 +207,7 @@ public double getCornerRadius() {
     }
 
     public RegularPolygon setCornerRadius(final double radius) {
-        this.cornerRadius = cornerRadius;
+        this.cornerRadius = radius;
 
         return refresh();
     }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/Shape.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/Shape.java
@@ -841,7 +841,7 @@ public LineJoin getLineJoin() {
      * @return T
      */
     public T setLineJoin(final LineJoin linejoin) {
-        this.lineJoin = lineJoin;
+        this.lineJoin = linejoin;
 
         return cast();
     }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/Spline.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/Spline.java
@@ -277,7 +277,7 @@ public double getAngleFactor() {
     }
 
     public Spline setAngleFactor(final double factor) {
-        this.angleFactor = angleFactor;
+        this.angleFactor = factor;
 
         return refresh();
     }

diff --git a/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/wires/IControlHandleFactory.java b/lienzo-core/src/main/java/com/ait/lienzo/client/core/shape/wires/IControlHandleFactory.java
@@ -23,7 +23,7 @@
 
 public interface IControlHandleFactory {
 
-    public Map<ControlHandleType, IControlHandleList> getControlHandles(ControlHandleType... types);
+    Map<ControlHandleType, IControlHandleList> getControlHandles(ControlHandleType... types);
 
-    public Map<ControlHandleType, IControlHandleList> getControlHandles(List<ControlHandleType> types);
+    Map<ControlHandleType, IControlHandleList> getControlHandles(List<ControlHandleType> types);
 }