Skip to content

Commit

Permalink
Fix the blog post order for the list page.
Browse files Browse the repository at this point in the history
  • Loading branch information
mblayman committed Jul 12, 2015
1 parent fdabdfe commit 2e6ffe3
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions handroll/extensions/blog.py
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@ def on_post_composition(self, director):
"""Generate blog output."""
if not self._should_generate:
return
blog_posts = sorted(self.posts.values(), key=lambda p: p.date)
blog_posts = sorted(
self.posts.values(), key=lambda p: p.date, reverse=True)
self._generate_atom_feed(director, blog_posts)
if self.list_template is not None:
self._generate_list_page(director, blog_posts)
Expand All @@ -117,8 +118,7 @@ def _generate_atom_feed(self, director, blog_posts):
"""Generate the atom feed."""
logger.info(_('Generating Atom XML feed ...'))
builder = FeedBuilder(self.atom_metadata)
# The feed expects oldest entries first.
builder.add(reversed(blog_posts))
builder.add(blog_posts)
output_file = os.path.join(director.outdir, self.atom_output)
builder.write_to(output_file)

Expand Down
6 changes: 3 additions & 3 deletions handroll/tests/test_blog_extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def test_adds_post(self, builder_add):
post = self.factory.make_blog_post()
extension.posts[post.source_file] = post
extension.on_post_composition(director)
received_post = next(builder_add.call_args[0][0])
received_post = builder_add.call_args[0][0][0]
self.assertEqual(post, received_post)

def test_date_in_post(self):
Expand Down Expand Up @@ -230,8 +230,8 @@ def test_posts_added_to_builder_by_date(self, builder_add):
os.mkdir(director.outdir)
extension.on_post_composition(director)
posts = builder_add.call_args[0][0]
self.assertEqual(older, next(posts))
self.assertEqual(current, next(posts))
self.assertEqual(older, posts[0])
self.assertEqual(current, posts[1])

def test_list_template_not_required(self):
director = self.factory.make_director()
Expand Down

0 comments on commit 2e6ffe3

Please sign in to comment.