Skip to content

Commit

Permalink
Smartify blog post titles on the list page.
Browse files Browse the repository at this point in the history
Fixes #50
  • Loading branch information
mblayman committed Apr 24, 2016
1 parent 515f5d3 commit 7838edd
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
4 changes: 3 additions & 1 deletion handroll/extensions/blog.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
except ImportError: # pragma: no cover
import configparser

import smartypants
from werkzeug.contrib.atom import AtomFeed, FeedEntry

from handroll import logger
Expand Down Expand Up @@ -210,9 +211,10 @@ def add(self, posts):
"""Add the posts and generate a blog list."""
li_html = []
for post in posts:
title = smartypants.smartypants(post.title)
li_html.append(
u'<li><a href="{route}">{title}</a></li>'.format(
route=post.route, title=post.title))
route=post.route, title=title))
self._blog_list = u'\n'.join(li_html)

def _generate_output(self):
Expand Down
9 changes: 9 additions & 0 deletions handroll/tests/test_blog_extension.py
Original file line number Diff line number Diff line change
Expand Up @@ -431,3 +431,12 @@ def test_adds_posts_to_blog_list_html(self):
'<li><a href="/a_source_file.html">A Blog Post</a></li>\n'
'<li><a href="/a_source_file.html">Another Blog Post</a></li>',
builder._blog_list)

def test_smartypants_conversion_on_title(self):
post = self.factory.make_blog_post()
post.title = 'An Emdash -- Post'
builder = ListPageBuilder(None)
builder.add([post])
self.assertEqual(
'<li><a href="/a_source_file.html">An Emdash &#8212; Post</a></li>',
builder._blog_list)

0 comments on commit 7838edd

Please sign in to comment.