Blog post titles are consistently smartified.

Fixes #68

handroll/extensions/blog.py

@@ -22,7 +22,7 @@ def __init__(self, **kwargs):
         self.date = kwargs['date']
         self.source_file = kwargs['source_file']
         self.summary = kwargs['summary']
-        self.title = kwargs['title']
+        self.title = smartypants.smartypants(kwargs['title'])
         self.route = kwargs['route']
         self.url = kwargs['url']
 
@@ -212,11 +212,9 @@ def add(self, posts):
         """Add the posts and generate a blog list."""
         li_html = []
         for post in posts:
-            # Put the smartified title back into the post.
-            post.title = title = smartypants.smartypants(post.title)
             li_html.append(
                 u'<li><a href="{route}">{title}</a></li>'.format(
-                    route=post.route, title=title))
+                    route=post.route, title=post.title))
         self._blog_list = u'\n'.join(li_html)
         self._posts = posts
 

handroll/tests/factory.py

@@ -13,16 +13,17 @@
 class Factory(object):
     """A factory to produce commonly needed objects"""
 
-    def make_blog_post(self):
-        kwargs = {
+    def make_blog_post(self, **kwargs):
+        parameters = {
             'date': datetime.datetime.today(),
             'source_file': 'a_source_file.md',
             'summary': 'The post summary',
             'title': 'A Blog Post',
             'route': '/a_source_file.html',
             'url': 'http://www.example.com/a_source_file.html',
         }
-        return BlogPost(**kwargs)
+        parameters.update(kwargs)
+        return BlogPost(**parameters)
 
     def make_configuration(self):
         config = Configuration()

handroll/tests/test_blog_extension.py

@@ -412,8 +412,7 @@ def test_adds_posts_to_blog_list_html(self):
             builder._blog_list)
 
     def test_smartypants_conversion_on_title(self):
-        post = self.factory.make_blog_post()
-        post.title = 'Emdash -- Post'
+        post = self.factory.make_blog_post(title='Emdash -- Post')
         builder = ListPageBuilder(None)
         builder.add([post])
         self.assertEqual(