Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify claim steps #20

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

handshake-enthusiast
Copy link
Contributor

@handshake-enthusiast handshake-enthusiast commented Apr 22, 2022

Remove unnecessary hs-client installation (see handshake-org/hsd#638 (comment)).

claim/index.html Outdated
@@ -100,27 +100,25 @@ <h2>System Setup</h2>
<p>Make sure you have nodejs and npm installed first. On MacOS, please install <a href="https://brew.sh">homebrew</a> and run "<b>brew install node unbound</b>". On debian/ubuntu, you can run "<b>sudo apt-get install nodejs npm build-essential libunbound-dev</b>". If you run other distributions or OSes, you can probably figure this part out.</p>
<p>Next, install node-gyp: <b>npm install node-gyp</b></p>
<h2>Download</h2>
<p>Download <b>hsd</b>, <b>hs-client</b>, and <b>hs-airdrop</b> from <a href="https://handshake.org/download/">https://handshake.org/download/</a>. If downloaded from github, the directory structure is slightly different (hsd-2.4.0/hsd should be replaced with just hsd in these instructions).</p>
<p>Extract hsd, hs-client, and hs-airdrop: <b>tar xvf hs*</b></p>
<p>Download <b>hsd</b> and <b>hs-airdrop</b> from <a href="https://handshake.org/download/">https://handshake.org/download/</a>. If downloaded from github, the directory structure is slightly different (hsd-3.0.1/hsd should be replaced with just hsd in these instructions).</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to not have to update this html page every time we release a new version - can it be worded so "latest release" works instead? Or maybe just "for example..."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just saw hsd-2.4.0/hsd above and decided to go ahead with the explicit versions, so it's easier to run (copy, paste, enter, success). OK, I can update a bit later. Alternatively, I can offer to update it every time when a new version is released.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to a wildcard, so you can proceed with merging as you prefer. My offer is still valid though 😉

@pinheadmz
Copy link
Member

Good idea, thanks. Let's just see if we can clean up the version numbers somehow. I think hsd-* was being used for future-proofing

rm unnecessary hs-client installation (see handshake-org/hsd#638 (comment))
@pinheadmz pinheadmz merged commit adb9d57 into handshake-org:gh-pages Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants