node: rescan expects buffer not string

[pinheadmz]

Closes handshake-org/hsd#357

[boymanjor]

tl;dr: should we keep the API consistent by accepting the String creating the Buffer for the users.

handshake-org/hsd#357 (comment)

[pinheadmz]

These aren't HTTP API endpoints though, they're socket calls. All the others assert Buffers:

hs-client/lib/node.js

Lines 231 to 273 in aa246e2

	/**
	* Send a transaction. Do not wait for promise.
	* @param {TX} tx
	* @returns {Promise}
	*/
	send(tx) {
	assert(Buffer.isBuffer(tx));
	return this.call('send', tx);
	}
	/**
	* Send a claim. Do not wait for promise.
	* @param {Claim} claim
	* @returns {Promise}
	*/
	sendClaim(claim) {
	assert(Buffer.isBuffer(claim));
	return this.call('send claim', claim);
	}
	/**
	* Get name state.
	* @param {Buffer} nameHash
	* @returns {Promise}
	*/
	getNameStatus(nameHash) {
	assert(Buffer.isBuffer(nameHash));
	return this.call('get name', nameHash);
	}
	/**
	* Set bloom filter.
	* @param {Bloom} filter
	* @returns {Promise}
	*/
	setFilter(filter) {
	assert(Buffer.isBuffer(filter));
	return this.call('set filter', filter);
	}

[boymanjor]

LGTM

[chjj]

This is as old as time. This is something I missed from the big string-to-buffer refactor. Not many people running hs-wallet as a separate daemon I guess.