Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bin/hsw-cli: reorder commands. #24

Closed
wants to merge 2 commits into from
Closed

bin/hsw-cli: reorder commands. #24

wants to merge 2 commits into from

Conversation

boymanjor
Copy link
Contributor

Previously, mkwallet was incorrectly designated an admin command. Likewise, master was not designated an admin command. This PR fixes this. H/t @bemusementpark for inspiring the investigation.

@boymanjor
Copy link
Contributor Author

boymanjor commented Mar 5, 2020

My hesitation in merging this comes from maintaining backwards compatibility for any bash scripts using mkwallet with the erroneous, leading admin sub command. Technically, this means a major version bump, but I'm not sure it is worth it.

@bemusementpark
Copy link

admin is not documented as an option when you run hsw-cli, so these commands are still not very discoverable.

hsw-cli admin
Unrecognized command.
Commands:
  $ wallets: List all wallets.
  $ wallet create [id]: Create wallet.
  $ resend: Resend pending transactions.
  $ backup [path]: Backup the wallet db.
  $ rpc [command] [args]: Execute RPC command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants