node: accept --no-dns configuration option to disable NS and RS

handshake-org · Feb 5, 2021 · c5f7901 · c5f7901
1 parent a94ce87
commit c5f7901
Show file tree

Hide file tree

Showing 3 changed files with 74 additions and 44 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 ## unreleased
 
+### Node changes
+
+- `FullNode` and `SPVNode` accept configuration parameter `--no-dns` (or `no-dns: true` in
+`hsd.conf`) which launches the node without either DNS server (the root authoritative
+server and the recursive resolver). This avoids some port collisions with other HNS resolvers like hnsd running locally, and generally separates and reduces security concerns around running unneeded servers when a node is just used for transactions and blocks.
+
 ### Wallet API changes
 
 - Adds new wallet HTTP endpoint `/wallet/:id/auction` based on `POST /wallet/:id/bid`.

diff --git a/lib/node/fullnode.js b/lib/node/fullnode.js
@@ -38,6 +38,9 @@ class FullNode extends Node {
 
     this.opened = false;
 
+    // Operate without DNS resolvers (just wallet and node)
+    this.noDNS = this.config.bool('no-dns', false);
+
     // SPV flag.
     this.spv = false;
 
@@ -147,24 +150,26 @@ class FullNode extends Node {
       cors: this.config.bool('cors')
     });
 
-    this.ns = new RootServer({
-      logger: this.logger,
-      key: this.identityKey,
-      host: this.config.str('ns-host'),
-      port: this.config.uint('ns-port', this.network.nsPort),
-      lookup: key => this.chain.db.tree.get(key),
-      publicHost: this.config.str('public-host')
-    });
-
-    this.rs = new RecursiveServer({
-      logger: this.logger,
-      key: this.identityKey,
-      host: this.config.str('rs-host'),
-      port: this.config.uint('rs-port', this.network.rsPort),
-      stubHost: this.ns.host,
-      stubPort: this.ns.port,
-      noUnbound: this.config.bool('rs-no-unbound')
-    });
+    if (!this.noDNS) {
+      this.ns = new RootServer({
+        logger: this.logger,
+        key: this.identityKey,
+        host: this.config.str('ns-host'),
+        port: this.config.uint('ns-port', this.network.nsPort),
+        lookup: key => this.chain.db.tree.get(key),
+        publicHost: this.config.str('public-host')
+      });
+
+      this.rs = new RecursiveServer({
+        logger: this.logger,
+        key: this.identityKey,
+        host: this.config.str('rs-host'),
+        port: this.config.uint('rs-port', this.network.rsPort),
+        stubHost: this.ns.host,
+        stubPort: this.ns.port,
+        noUnbound: this.config.bool('rs-no-unbound')
+      });
+    }
 
     this.init();
   }
@@ -259,8 +264,12 @@ class FullNode extends Node {
     await this.openPlugins();
 
     await this.http.open();
-    await this.ns.open();
-    await this.rs.open();
+
+    if (!this.noDNS) {
+      await this.ns.open();
+      await this.rs.open();
+    }
+
     await this.handleOpen();
 
     if (this.has('walletdb')) {
@@ -286,8 +295,11 @@ class FullNode extends Node {
 
     await this.handlePreclose();
     await this.http.close();
-    await this.rs.close();
-    await this.ns.close();
+
+    if (!this.noDNS) {
+      await this.rs.close();
+      await this.ns.close();
+    }
 
     await this.closePlugins();
 

diff --git a/lib/node/spvnode.js b/lib/node/spvnode.js
@@ -40,6 +40,9 @@ class SPVNode extends Node {
 
     this.opened = false;
 
+    // Operate without DNS resolvers (just wallet and node)
+    this.noDNS = this.config.bool('no-dns', false);
+
     // SPV flag.
     this.spv = true;
 
@@ -93,24 +96,26 @@ class SPVNode extends Node {
       cors: this.config.bool('cors')
     });
 
-    this.ns = new RootServer({
-      logger: this.logger,
-      key: this.identityKey,
-      host: this.config.str('ns-host'),
-      port: this.config.uint('ns-port', this.network.nsPort),
-      lookup: key => this.pool.resolve(key),
-      publicHost: this.config.str('public-host')
-    });
-
-    this.rs = new RecursiveServer({
-      logger: this.logger,
-      key: this.identityKey,
-      host: this.config.str('rs-host'),
-      port: this.config.uint('rs-port', this.network.rsPort),
-      stubHost: this.ns.host,
-      stubPort: this.ns.port,
-      noUnbound: this.config.bool('rs-no-unbound')
-    });
+    if (!this.noDNS) {
+      this.ns = new RootServer({
+        logger: this.logger,
+        key: this.identityKey,
+        host: this.config.str('ns-host'),
+        port: this.config.uint('ns-port', this.network.nsPort),
+        lookup: key => this.pool.resolve(key),
+        publicHost: this.config.str('public-host')
+      });
+
+      this.rs = new RecursiveServer({
+        logger: this.logger,
+        key: this.identityKey,
+        host: this.config.str('rs-host'),
+        port: this.config.uint('rs-port', this.network.rsPort),
+        stubHost: this.ns.host,
+        stubPort: this.ns.port,
+        noUnbound: this.config.bool('rs-no-unbound')
+      });
+    }
 
     this.init();
   }
@@ -172,8 +177,12 @@ class SPVNode extends Node {
     await this.openPlugins();
 
     await this.http.open();
-    await this.ns.open();
-    await this.rs.open();
+
+    if (!this.noDNS) {
+      await this.ns.open();
+      await this.rs.open();
+    }
+
     await this.handleOpen();
 
     this.logger.info('Node is loaded.');
@@ -190,8 +199,11 @@ class SPVNode extends Node {
 
     await this.handlePreclose();
     await this.http.close();
-    await this.rs.close();
-    await this.ns.close();
+
+    if (!this.noDNS) {
+      await this.rs.close();
+      await this.ns.close();
+    }
 
     await this.closePlugins();