Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bslint as dependency causes vulnerabilities log on install #489

Closed
tynes opened this issue Aug 7, 2020 · 1 comment · Fixed by #494
Closed

bslint as dependency causes vulnerabilities log on install #489

tynes opened this issue Aug 7, 2020 · 1 comment · Fixed by #494

Comments

@tynes
Copy link
Contributor

tynes commented Aug 7, 2020

I know that this is very common in the JavaScript space, but now that bslint is a devDependency, this error message logs on an npm install:

found 6 vulnerabilities (2 low, 1 moderate, 2 high, 1 critical)
  run `npm audit fix` to fix them, or `npm audit` for details

Maybe there is a way we can have the Github actions install bslint as a prehook to the installation process so that we don't have to worry about this locally.

@pinheadmz
Copy link
Member

Damn I got https://github.com/bcoin-org/bslint and https://github.com/chjj/bslint/ mixed up. The chjj repo is what's published to npm and although the dependencies are committed in the git repo, we still need to heed the security warnings. I guess there's a reason the linter was never added to deps before :-( Will have to install separately in the github workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants