Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove bslint as dep. Install manually in workflows. Explain process in new CONTRIBUTING guide #494

Merged
merged 3 commits into from Aug 11, 2020

Conversation

pinheadmz
Copy link
Member

Closes #489

Removes bslint from dependencies and installs it manually in workflows process for CI testing.

Added a CONTIRBUTING.md guide to explain how to install and use bslint since it is not automatic anymore. While there, added sections about bmocha and commit message preferences.

Linked that from README and, while there, removed the short list of RPC commands that we don't maintain and just linked to the API docs.

@pinheadmz
Copy link
Member Author

Installed on a fresh VPS:

 npm audit

                       === npm audit security report ===

found 0 vulnerabilities
 in 38 scanned packages

looks ok. npm run lint of course failed until I installed bslint manually, then lint test works. Looks like gtihub CI works as expected as well.

@coveralls
Copy link

coveralls commented Aug 10, 2020

Pull Request Test Coverage Report for Build 204024484

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 58.983%

Totals Coverage Status
Change from base Build 202553015: 0.007%
Covered Lines: 19286
Relevant Lines: 30406

💛 - Coveralls

Copy link
Contributor

@tuxcanfly tuxcanfly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@tynes tynes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a3c34bc
Nit: some squashing could be useful

@pinheadmz pinheadmz changed the title Remove bslint as dep. Install manually in workflows. Explain process in new CONTIRBUTING guide Remove bslint as dep. Install manually in workflows. Explain process in new CONTRIBUTING guide Aug 11, 2020
also move API link to top of quickstart section in README
explain lint

explain commit message preferences in CONTIRBUTING
@pinheadmz
Copy link
Member Author

rebase to 9fafb91:

Just squashin -- diff should be null

@pinheadmz pinheadmz merged commit b77e2dc into handshake-org:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bslint as dependency causes vulnerabilities log on install
4 participants