Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet: always apply balance deltas to lockedUnconfirmed balance #385

Closed
wants to merge 1 commit into from
Closed

wallet: always apply balance deltas to lockedUnconfirmed balance #385

wants to merge 1 commit into from

Conversation

pinheadmz
Copy link
Member

Closes #381

Explanation here: #381 (comment)

TODO:

  • write unit test.

@pinheadmz pinheadmz changed the title wallet: always apply to unconf locked balance wallet: always apply balance deltas to lockedUnconfirmed balance Mar 8, 2020
boymanjor
boymanjor reviewed Mar 10, 2020
View reviewed changes
Copy link
Contributor

@boymanjor boymanjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work tracking this down. Standing by for tests before I do a full review.

@pinheadmz
Copy link
Member Author

@boymanjor yah standby indeed, this patch is wrong. I'm counting unconfirmed TXs twice. I think the approach needs to be more like #262

@pinheadmz pinheadmz mentioned this pull request Mar 10, 2020
Merged
@pinheadmz
Copy link
Member Author

this approach was totally wrong, new PR is here: #387

@pinheadmz pinheadmz closed this Mar 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boymanjor boymanjor boymanjor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assertion failed when calling sendredeem or sendupdate on imported wallet
2 participants
@pinheadmz @boymanjor