Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: fix the return of POST /reveal and /redeem #532

Merged
merged 1 commit into from
Jan 11, 2021
Merged

wallet: fix the return of POST /reveal and /redeem #532

merged 1 commit into from
Jan 11, 2021

Conversation

peipeitu
Copy link

@peipeitu peipeitu commented Jan 8, 2021

Fix the return of POST /reveal and /redeem when no name provided.

@peipeitu peipeitu changed the title wallet-http: fix the return of POST /reveal and /redeem wallet: fix the return of POST /reveal and /redeem Jan 8, 2021
@coveralls
Copy link

coveralls commented Jan 8, 2021

Pull Request Test Coverage Report for Build 470580220

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 5 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.005%) to 59.41%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/wallet/http.js 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
lib/protocol/consensus.js 1 82.79%
lib/utils/binary.js 1 56.9%
lib/net/pool.js 3 32.49%
Totals Coverage Status
Change from base Build 377501416: -0.005%
Covered Lines: 19428
Relevant Lines: 30472

💛 - Coveralls

@coveralls
Copy link

Pull Request Test Coverage Report for Build 470580220

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.002%) to 59.413%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/wallet/http.js 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
lib/covenants/rules.js 1 67.06%
lib/net/pool.js 1 32.56%
lib/protocol/consensus.js 1 82.79%
lib/script/script.js 1 63.07%
Totals Coverage Status
Change from base Build 377501416: -0.002%
Covered Lines: 19429
Relevant Lines: 30472

💛 - Coveralls

Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e5cb964

Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

ACK e5cb9645345e7fa1d4fbb169a832abc05efebffa
-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAl/8fpkACgkQ5+KYS2KJ
yTqndBAA2CJXGW39dGcPdbeZ7Dsq/AYmaMtPmmwbQAMVodY98b99goBnm5zTI5DC
rSUs7WURb1S78pL4IXDPNnawEZGSSOJyou/oeEdY7x9vO50ufH4oFmAaFKiJI3qO
KUjApKkbi2ux2JcvLTZT/Xhtf0seJD0OUM3Lg5LbNMk0Wt2a/8rN2omqXgBtBGTU
BnNYz0Mfw166YeIEfP9wZmEKqSxPLAiNY624hAsAxVv+W+orZeJJqO20Ht23cBJN
IQ0PeDh0GrL41v4M2tTwqliqiaHO69CD3kcCtqYaIZqmDDeq6rZPNKuDJyWw9pgW
4IgWhJhwgxGCxyBkLJZbVwjgJp7oFJvZ0gv3ln6RwlPpNGHxlQTXOhKYIi+wMccH
E+VxVSiuildgOLSJ2rmd0TXvEgmmbTa9AwhqogcwS00kcC81eR9SFHRHiSAsgKiK
ZZo2Z8RP1QGCBO+R+GIu5wjzAzU4toe+ftP4YyCiSyagZ098f9n+iwgdiIOdrI6G
cHEAPCGLvUgcCmI0a8YrYQen7qZ6WCeIefcx9J2LkcQYKecvMpT6KvoIYHs6jVHU
xG7lSpaWCVBAkTg6p7UcyMkbvHvVSRZ5Xwxw68t7Mng00532dlEP18JW1iB8nDYi
waTl3+atAzZaI8lXkFh/aLh2CNgvkWkJKrrPSC0vTs3WCZ0c3bo=
=bqQz
-----END PGP SIGNATURE-----

pinheadmz's public key is on keybase

@pinheadmz pinheadmz merged commit 4042141 into handshake-org:master Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants