dns: make request info available to plugins #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 670218928
💛 - Coveralls |
pinheadmz
approved these changes
Mar 22, 2021
There was a problem hiding this comment.
ACK 50001e2
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK 50001e2e0b1eee7c02c52bb213d80b403c319f5f
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmBYvh4ACgkQ5+KYS2KJ
yTo0dA//a/J9nHj6nnK88WIp3vHysqz0/fxxUq7aIGyywVzQ6dNJVbiDI3GNysgf
0z28B8eKGX/8/HSP3vfGGPRqFZK1Sh6fgDWby60acMwzIC3EUxy/ivhRCXDT9IDy
lUPWBK4JPJ4RDtiPDj0/n18kckVSAl2eWM54zXMiZiB6lFo8W9HPjIDDIj/ICVjV
XLVSz0eMdFLrEVX3Y/N4aX1NhMmnlrK/UHGyUHooIYsRYtyrTQhRs9U38Cp59INf
ZO9Fzic76F6diuA/xEvULUrmC2aIPR3OzOLTrUmWoaP/7yf72ErENvLEQIj+Ddl+
8OOWfQ8Du7hClyO40vE/79geC/BE9sjCRJniKh+hqbosbvAKjLyFl3ZSX+ghkewN
w6pcEXHAC+P/3DO7N+tsb4YjWUb4nXGRwRZYPi9AZ3/bMa4B8tBWyavYO5dCWQY1
A9vkq8DCU5UY9TUY3Ln3hctzbk3DOl0HkoWX9pgh49ArCYIKSbU5BXAjk72s+qH3
/5PIOqCUDxw3b5WF9D9QN5zLEgbtls1w3djbHDwjkvaaATpxKu7PESSFRLiuGKX3
dkDhKrs7oqlv74ob15duCKaumNZBBeLJd7qhGPFxewCgohSvi/hNBxAvkX+mgwJi
ApJTcPokrHcud5oqCr9e+0dKHP5410K6G7aEpebN+n/5IULD6PU=
=nLoo
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the request info available to plugins can be very useful. For example, to do access control based on IP address (bind has this feature). Also, Implementing some advanced features in DNS that requires knowing the protocol, port and IP address like the HSD AXFR plugin which needs rinfo to send multiple dns messages over TCP.