Sign & verify message with name #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 922544001
💛 - Coveralls |
pinheadmz
requested changes
Jun 8, 2021
There was a problem hiding this comment.
Great job on this dude! Very cool and fun to play with on command line as well:
--> hsw-rpc signmessagewithname test-txt "Falci is handsome."
CUjgakQfpOG9aTa4DzKaX9heuYZW2D26tZ9pb6VEgco5pLNuU8NljSQn2DtAFGkpEiEugNYNh94W7JZAjKuWkQ==
--> hsd-rpc verifymessagewithname test-txt CUjgakQfpOG9aTa4DzKaX9heuYZW2D26tZ9pb6VEgco5pLNuU8NljSQn2DtAFGkpEiEugNYNh94W7JZAjKuWkQ== "Falci is handsome."
true
--> hsd-rpc verifymessagewithname test-txt CUjgakQfpOG9aTa4DzKaX9heuYZW2D26tZ9pb6VEgco5pLNuU8NljSQn2DtAFGkpEiEugNYNh94W7JZAjKuWkQ== "Falci is not handsome."
false
|
Oh one more thing: please add these new RPC methods to the CHANGELOG! |
|
As discussed, both sign and verify should check if name is |
pinheadmz
requested changes
Jun 9, 2021
pinheadmz
requested changes
Jun 9, 2021
lib/node/rpc.js
Outdated
| } | ||
|
|
||
| const address = coin.address.toString(this.network); | ||
| return this.verifyMessage([address, sig, str], help); |
There was a problem hiding this comment.
I don't think you need to pass help here. If help were true, we'd throw an error right away, and we don't want to return help from a different RPC call anyway. Applies to both functions.
lib/wallet/rpc.js
Outdated
Comment on lines
1604
to
1605
| if (!wallet.master.key) | ||
| throw new RPCError(errs.WALLET_UNLOCK_NEEDED, 'Wallet is locked.'); |
There was a problem hiding this comment.
I don't think we need this here, it will be checked in signMessage() and we don't need to decrypt the wallet until then anyway.
pinheadmz
approved these changes
Jun 9, 2021
There was a problem hiding this comment.
ACK f1e096f
Show Signature
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
ACK f1e096ff1faa7b9ee56415f37e5fe55286ec3a55
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5hdzzW4BBA4vG9eM5+KYS2KJyToFAmDBDOAACgkQ5+KYS2KJ
yTox3xAAqMLyvBNxI0MCIy8W2JwLFAOM5FsbC6kf7GQ9zO7rgYPjUWtIBIg8ECW0
vYd/kPlXU0I86hDYEGnUtwW3P6uX+SERhR6AVPW+mbxPJlT2MZ7LfzAMXAXLxfTV
umm6fzWsHXUj9H59FZX3eFkGpZ6fcofZck4/5NMsaiHBffZLbeP/uQN8sFC1NTEw
c1orML4rrstolIX9km9AZoOkecZXl0eRmEg9HMPlSpNnZHFokW8TFgpDvlqPQC0g
2zfPvTHtISSyULwEsAuwq4464ad9ZZLpppFx3lED22SW1d5IxqwjHH4iSqC9L4zp
f45CoDsbbOoocbCAyMwuPRg7QaiDeLYxdR1ijIc3AlKmHHSUPzOM1xU6e3vt/pxt
5/ZtwAKHwzcfSh/l9aUXvDXuEt0L1v+ra5lfUzr6MKtICdCrNsoJxHIXq4uBI1JP
Td03E5xH5b80xEZt3YwupliN/2ShSRYc+8RieZSLLB+9GhpWwMSM/pE2IUT1vWnX
tyhvdL//ledI/eRHwdoeZ9aYQsiRJz/5H9xXoP1q3RfQ+rYWUWf2yXtqDRJ6Gc1I
dPcnpdkK6hfDTQn/41FRnQFWQ9ueZFHMXZWtRPP07sfSd5alrYCqWeP6Q7IG588E
N+nYe/ZWvn6xWksJ2iW5stUNyK9hdVoF8SLlhqVHXATcmAXo3DQ=
=dTW7
-----END PGP SIGNATURE-----
pinheadmz's public key is on keybase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#606 item 2: Create new RPCs
signmessagewithnameandverifymessagewithname