Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hard-coded ICANN fallback and re-include names.json in npm package #648

Merged
merged 2 commits into from Oct 21, 2021

Conversation

pinheadmz
Copy link
Member

commit ecc4987:
dns: remove unused hard-coded ICANN fallback
This was added in f45bd0f and not required or used by any other module. I don't think it has ever been used. The root zone included in this file is out of date and I looking at the next commit I think @chjj thought it was too big a file to include in the package anyway. Closes this comment of this issue: #603 (comment)

commit cbad4d6:
pkg: include consensus-critical json files in npm package
This reverts 9a1dda0 which reverted e3a6e71 which reverted 9b61bf7. I wish I knew what the issue was with these files but names.json at least is consensus critical in the browser environment (like Bob's front end) and since MTX and Address require covenants which requires reserved, we can't just discard it.

Added in f45bd0f
and not required or used by any other module.
@coveralls
Copy link

coveralls commented Oct 18, 2021

Pull Request Test Coverage Report for Build 1355972148

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.007%) to 62.25%

Files with Coverage Reduction New Missed Lines %
lib/covenants/rules.js 1 69.11%
Totals Coverage Status
Change from base Build 1343021118: -0.007%
Covered Lines: 21190
Relevant Lines: 31820

💛 - Coveralls

@pinheadmz pinheadmz merged commit 1e22ba4 into handshake-org:master Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants