Remove hard-coded ICANN fallback and re-include names.json in npm package #648
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit ecc4987:
dns: remove unused hard-coded ICANN fallback
This was added in f45bd0f and not required or used by any other module. I don't think it has ever been used. The root zone included in this file is out of date and I looking at the next commit I think @chjj thought it was too big a file to include in the package anyway. Closes this comment of this issue: #603 (comment)
commit cbad4d6:
pkg: include consensus-critical json files in npm package
This reverts 9a1dda0 which reverted e3a6e71 which reverted 9b61bf7. I wish I knew what the issue was with these files but names.json at least is consensus critical in the browser environment (like Bob's front end) and since MTX and Address require covenants which requires reserved, we can't just discard it.