wallet: remove force option from wallet.makeOpen. #815
Conversation
nodech
added
quick
nodech
added
patch
| - HTTP Changes: | ||
| - `/wallet/:id/open` no longer accepts `force` flag. (it was not used) | ||
| - RPC Changes: | ||
| - `createopen` and `sendopen` no longer accept `force` as an argument. (was not used) |
There was a problem hiding this comment.
It feels repetitive, but since hsd can used as a library, does it make sense to also add wallet.{create,send}Open() change here?
There was a problem hiding this comment.
It sounds too much to me. It would be good to document every change like that for the lower level consumers of the hsd, but given the ability to reorganize/refactor some code that does not break intended API that is HTTP/RPC only - gives us more flexibility.
I would consider changes to MTX/TX/Script etc primitives that are almost necessary in some front-end cases (e.g. working with ledger etc) to be part of the breaking changes.
Given wallet is meant to be consumed via HTTP, I think documenting this as a breaking change to become more troublesome. If we were to go that way, every change to any class should be documented here as well, as more involved use cases may use those.
So, in summary, I would stick to the current rules: document breaking API (HTTP/RPC/DNS) and MAYBE primitives.
nodech
force-pushed
the
wallet-open-cleanup
branch
from
2f0e520
to
74a8643
Compare
|
Rebased |
nodech
force-pushed
the
wallet-open-cleanup
branch
from
74a8643
to
ae79174
Compare
forceoption is leftover after refactors as far as I can see in the history.As it is not used and no one knows why it was there, might as well clean up.