Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: refactor createTX to be more flexible #816

Merged
merged 1 commit into from
May 29, 2023

Conversation

nodech
Copy link
Contributor

@nodech nodech commented May 25, 2023

Remove fundlock force hack for the send.

It now will repeat the same signature as others like it. (open, bid, ..)

@nodech nodech added refactor general - rewriting code quick review difficulty - easy wallet part of the codebase cleanup improvement classification patch Release version labels May 25, 2023
@coveralls
Copy link

Coverage Status

Coverage: 68.44% (-0.0007%) from 68.44% when pulling 4392dcc on nodech:wallet-create-tx into 2bb8f0b on handshake-org:master.

Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@nodech nodech merged commit 61c1e05 into handshake-org:master May 29, 2023
5 checks passed
@nodech nodech deleted the wallet-create-tx branch June 18, 2023 09:04
nodech added a commit that referenced this pull request Jul 17, 2023
@nodech nodech mentioned this pull request Jul 17, 2023
This was referenced Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup improvement classification patch Release version quick review difficulty - easy refactor general - rewriting code wallet part of the codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants