Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet-http: reveals all now can be created without broadcasting. #818

Merged
merged 1 commit into from
May 31, 2023
Merged

wallet-http: reveals all now can be created without broadcasting. #818

merged 1 commit into from
May 31, 2023

Conversation

nodech
Copy link
Contributor

@nodech nodech commented May 30, 2023

Noticed on previous pr.

Now revealAll will be similar to redeemAll.

@nodech nodech requested a review from rithvikvibhu May 30, 2023 15:58
@nodech nodech added the wallet part of the codebase label May 30, 2023
rithvikvibhu
rithvikvibhu approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@rithvikvibhu rithvikvibhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can create reveal all without broadcast now 👍
I think the other change for readability? Doesn't affect anything.

@nodech nodech merged commit 5bed384 into handshake-org:master May 31, 2023
5 checks passed
@nodech nodech deleted the fix-wallet-http-revealall branch May 31, 2023 13:34
This was referenced Aug 5, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithvikvibhu rithvikvibhu rithvikvibhu approved these changes

Assignees
No one assigned
Labels
wallet part of the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nodech @rithvikvibhu