wallet: fix makeBatch to generate addresses early #825
Conversation
lib/wallet/wallet.js
Outdated
| * @returns {Promise<MTX>} | ||
| */ | ||
|
|
||
| async makeOpen(name, acct, mtx) { | ||
| async makeOpen(name, acct, mtx, addr) { |
There was a problem hiding this comment.
If addr is provided then acct has no use.
There was a problem hiding this comment.
Hm true. But acct is mandatory and also matches other make* methods signatures. Not sure what can be done
rithvikvibhu
force-pushed
the
makebatch-addr-fix
branch
from
0e18f95
to
dee6d2e
Compare
rithvikvibhu
force-pushed
the
makebatch-addr-fix
branch
3 times, most recently
from
cd94b88
to
5ed8d30
Compare
|
So, previous code was generating new address for every bid, but because receiveAddress in makeBid does not increment the depth it was using the cleanup phase to repopulate them with different depth/addresses. Also for the BID it's critical for constructing nonce and now we can pass these addrs even before, so we can avoid this issue. Do we really want to pass ADDR to the OPEN though ? I believe it does not use that address for anything and can easily be outside. Only BID has trouble with it. |
rithvikvibhu
force-pushed
the
makebatch-addr-fix
branch
from
5ed8d30
to
c88837f
Compare
|
|
rithvikvibhu
force-pushed
the
makebatch-addr-fix
branch
from
ba491a0
to
9b6b750
Compare
Bid actions in makeBatch had their addresses overridden after nonce generation, making it impossible to recover the wallet with importnonce. With this change, the address is derived and passed to make* so the correct address is used to generate nonces.
rithvikvibhu
force-pushed
the
makebatch-addr-fix
branch
from
9b6b750
to
c4aeec4
Compare
Bid actions in
makeBatchhad their addresses overridden after nonce generation, making it impossible to recover the wallet with importnonce.With this change, the address is derived and passed to make* so the correct address is used to generate nonces.
The test covers both
sendbidandsendbatch.