covenant: set methods on covenant. #866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodech
added
intermediate
rithvikvibhu
approved these changes
Oct 19, 2023
Comment on lines
+498
to
+499
| this.pushU8(address.version); | ||
| this.push(address.hash); |
There was a problem hiding this comment.
Would an assert(address instanceof Address) make sense here? pushU8 and push will catch them anyway ig.
|
Seeing proper type hints is refreshing ❤️
|
nodech
force-pushed
the
covenant-methods
branch
from
ce1c65b
to
0f4767f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add helper methods on covenant for every type.
Part of #703 and #619