Remove double borders for column headers (#10948)

handsontable · Apr 26, 2024 · e32f4db · e32f4db
1 parent 9ed2854
commit e32f4db
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 11 deletions.
diff --git a/.changelogs/10948.json b/.changelogs/10948.json
@@ -0,0 +1,8 @@
+{
+  "issuesOrigin": "private",
+  "title": "Removed double borders for column headers",
+  "type": "fixed",
+  "issueOrPR": 10948,
+  "breaking": false,
+  "framework": "none"
+}
diff --git a/handsontable/src/3rdparty/walkontable/css/walkontable.scss b/handsontable/src/3rdparty/walkontable/css/walkontable.scss
@@ -97,7 +97,6 @@
 }
 
 .handsontable th:first-child,
-.handsontable th:nth-child(2),
 .handsontable td:first-of-type {
   border-inline-start: 1px solid #ccc;
 }

diff --git a/handsontable/src/3rdparty/walkontable/test/spec/table.spec.js b/handsontable/src/3rdparty/walkontable/test/spec/table.spec.js
@@ -556,8 +556,7 @@ describe('WalkontableTable', () => {
 
       expect($('.ht_clone_top_inline_start_corner thead tr th').eq(0).css('border-left-width')).toBe('1px');
       expect($('.ht_clone_top_inline_start_corner thead tr th').eq(0).css('border-right-width')).toBe('1px');
-      // was 0 before https://github.com/handsontable/handsontable/commit/32c163c6a98903a30daddac7582276d18a12a81a
-      expect($('.ht_clone_top_inline_start_corner thead tr th').eq(1).css('border-left-width')).toBe('1px');
+      expect($('.ht_clone_top_inline_start_corner thead tr th').eq(1).css('border-left-width')).toBe('0px');
       expect($('.ht_clone_top_inline_start_corner thead tr th').eq(1).css('border-right-width')).toBe('1px');
     });
   });

diff --git a/handsontable/src/plugins/manualColumnResize/__tests__/manualColumnResize.spec.js b/handsontable/src/plugins/manualColumnResize/__tests__/manualColumnResize.spec.js
@@ -277,7 +277,7 @@ describe('manualColumnResize', () => {
 
     const $columnHeaders = spec().$container.find('thead tr:eq(0) th');
 
-    expect($columnHeaders.eq(1).width()).toBe(33);
+    expect($columnHeaders.eq(1).width()).toBe(34);
     expect($columnHeaders.eq(2).width()).toBe(34);
     expect($columnHeaders.eq(3).width()).toBe(34);
   });
@@ -341,7 +341,7 @@ describe('manualColumnResize', () => {
 
     const $columnHeaders = spec().$container.find('thead tr:eq(0) th');
 
-    expect($columnHeaders.eq(1).width()).toBe(154);
+    expect($columnHeaders.eq(1).width()).toBe(155);
     expect($columnHeaders.eq(2).width()).toBe(155);
     expect($columnHeaders.eq(3).width()).toBe(155);
   });
@@ -395,7 +395,7 @@ describe('manualColumnResize', () => {
     const $columnHeaders = spec().$container.find('thead tr:eq(0) th');
 
     expect($columnHeaders.eq(0).width()).toBe(63);
-    expect($columnHeaders.eq(1).width()).toBe(48);
+    expect($columnHeaders.eq(1).width()).toBe(49);
     expect($columnHeaders.eq(2).width()).toBe(49);
     expect($columnHeaders.eq(3).width()).toBe(49);
     expect($columnHeaders.eq(4).width()).toBe(694);
@@ -412,7 +412,7 @@ describe('manualColumnResize', () => {
     await sleep(1000);
 
     expect($columnHeaders.eq(0).width()).toBeAroundValue(19);
-    expect($columnHeaders.eq(1).width()).toBe(48);
+    expect($columnHeaders.eq(1).width()).toBe(49);
     expect($columnHeaders.eq(2).width()).toBe(49);
     expect($columnHeaders.eq(3).width()).toBe(49);
     expect($columnHeaders.eq(4).width()).toBeAroundValue(738);
@@ -449,7 +449,7 @@ describe('manualColumnResize', () => {
       await sleep(1000);
 
       expect($columnHeaders.eq(0).width()).toBe(24);
-      expect($columnHeaders.eq(1).width()).toBe(118);
+      expect($columnHeaders.eq(1).width()).toBe(119);
       expect($columnHeaders.eq(2).width()).toBe(159);
       expect($columnHeaders.eq(3).width()).toBe(59);
       expect($columnHeaders.eq(4).width()).toBe(79);
@@ -467,7 +467,7 @@ describe('manualColumnResize', () => {
       await sleep(1000);
 
       expect($columnHeaders.eq(0).width()).toBe(24);
-      expect($columnHeaders.eq(1).width()).toBe(69);
+      expect($columnHeaders.eq(1).width()).toBe(70);
       expect($columnHeaders.eq(2).width()).toBe(159);
       expect($columnHeaders.eq(3).width()).toBe(59);
       expect($columnHeaders.eq(4).width()).toBe(79);

diff --git a/handsontable/src/plugins/manualColumnResize/__tests__/rtl/manualColumnResize.spec.js b/handsontable/src/plugins/manualColumnResize/__tests__/rtl/manualColumnResize.spec.js
@@ -44,7 +44,7 @@ describe('manualColumnResize (RTL)', () => {
 
     const $columnHeaders = spec().$container.find('thead tr:eq(0) th');
 
-    expect($columnHeaders.eq(1).width()).toBe(20);
+    expect($columnHeaders.eq(1).width()).toBe(21);
     expect($columnHeaders.eq(2).width()).toBe(21);
     expect($columnHeaders.eq(3).width()).toBe(21);
   });
@@ -77,7 +77,7 @@ describe('manualColumnResize (RTL)', () => {
 
     const $columnHeaders = spec().$container.find('thead tr:eq(0) th');
 
-    expect($columnHeaders.eq(1).width()).toBe(199);
+    expect($columnHeaders.eq(1).width()).toBe(200);
     expect($columnHeaders.eq(2).width()).toBe(200);
     expect($columnHeaders.eq(3).width()).toBe(200);
   });