unify DOM of examples and search for table by ID #10193

maciejbo-handsontable · 2022-12-28T20:46:13Z

We need to unify DOM of examples to be sure that we are looking for correct element in visual testing

Launched locally and in Github Action if fork built for visual testing - all of tests passed correctly.

Bug fix (non-breaking change which fixes an issue)
New feature or improvement (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
Additional language file or change to the existing one (translations)

I have reviewed the guidelines about Contributing to Handsontable and I confirm that my code follows the code style of this project.
I have signed the Contributor License Agreement
My change requires a change to the documentation.

[skip changelog]

unify DOM of examples and search for table by ID

277e6b7

maciejbo-handsontable requested a review from jansiegel December 28, 2022 20:49

maciejbo-handsontable mentioned this pull request Jan 12, 2023

visual testing - implement proof of concept into HOT repo #10165

Merged

3 tasks

jansiegel approved these changes Jan 13, 2023

View reviewed changes

budnix assigned maciejbo-handsontable Jan 13, 2023

maciejbo-handsontable merged commit 072a9ed into feature/dev-issue-572 Jan 13, 2023

maciejbo-handsontable deleted the feature/dev-issue-962 branch January 13, 2023 10:52

Provide feedback