Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark an internal prop of the React wrapper's base editor component as optional. #10429

Merged
merged 2 commits into from Jun 28, 2023

Conversation

jansiegel
Copy link
Member

Context

As pointed out by @samsullivan in #10263 (comment), the React wrapper's internal editorColumnScope prop should be marked as optional.

This PR:

  • Marks the editorColumnScope in the base editor component as optional.
  • Makes the editorColumnScope types more precise.

How has this been tested?

Tested manually + automatically.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

- Make the 'editorColumnScope' types more precise
@jansiegel jansiegel requested a review from budnix June 28, 2023 07:08
@jansiegel jansiegel self-assigned this Jun 28, 2023
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samsullivan
Copy link

Thanks!! CC @trey-miller.

@jansiegel jansiegel merged commit 9c268d8 into develop Jun 28, 2023
21 checks passed
@jansiegel jansiegel deleted the feature/correct-internal-react-wrapper-types branch June 28, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants