Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Autofill doesn't work properly when we unmerge already merged area #10456

Closed
wszymanski opened this issue Jul 31, 2023 · 2 comments
Closed

Comments

@wszymanski
Copy link
Contributor

Describe the bug

After performing an unmerge on some merge area there are some problems with populating data previously covered by the merge.

Video/Screenshots

bug_merge_autofill.mp4

Provide a link to the demo with the bug reproduction

No response

Handsontable version

< 13

Framework version

No response

Your environment

doesn't matter

@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 17, 2023

Tested using this demo https://jsfiddle.net/kvf3d2xh/2/ on Chrome 115 and Firefox 116 on macOS Ventura.

Steps to replicate based on the video

  1. Unmerge the E4 cell
  2. Autofill E4 down to E6
  3. Autofill E4 right to G6
  4. Autofill F4 down to F6 - this is where it fails

After doing all of the above steps in pre 13.1.0 demo we are able to populate data correctly. The issue is solved.

Also checking the hook

afterSelectionEnd: function(r, c, r2, c2, layer){
  console.log(this.getCellMeta(r, c).copyable)
}

we got false after the step 4, now in pre 13.1.0 we get true

I also tested a similar scenario where we

  1. Unmerge cell B2
  2. Autofill B2 right to C2
  3. Autofill C2 down

as this scenario also failed in v13.0.0. Thankfully, it also works well in the newest version.

@AMBudnik
Copy link
Contributor

Demo updated to released v13.1.0 https://jsfiddle.net/tv7zx50c/ works well.

Issue closed as solved in Handsontable v13.1.0

wszymanski added a commit that referenced this issue Nov 10, 2023
…en necessary) (#10444)

Co-authored-by: Krzysztof Budnik <571316+budnix@users.noreply.github.com>
Fixed problem with data population and wrote e2e tests #10456
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants