Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the missing type definition for BaseEditor's getEditedCellRect method. #10459

Merged
merged 4 commits into from Aug 8, 2023
Merged

Add the missing type definition for BaseEditor's getEditedCellRect method. #10459

merged 4 commits into from Aug 8, 2023

Conversation

jansiegel
Copy link
Member

Context

This PR:

  • Adds the missing type definition for BaseEditor's getEditedCellRect method.
  • Extend the editors' type test.

How has this been tested?

The extended tests check if the added method definition exists.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature or improvement (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Additional language file or change to the existing one (translations)

Affected project(s):

  • handsontable
  • @handsontable/angular
  • @handsontable/react
  • @handsontable/vue
  • @handsontable/vue3

Checklist:

@jansiegel jansiegel marked this pull request as ready for review August 4, 2023 06:46
@jansiegel jansiegel requested a review from budnix August 4, 2023 06:46
budnix
budnix approved these changes Aug 7, 2023
View reviewed changes
Copy link
Member

@budnix budnix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@AMBudnik
Copy link
Contributor

AMBudnik commented Aug 8, 2023

[note to myself] Update forum topic upon release.

@jansiegel jansiegel merged commit ba8b82e into develop Aug 8, 2023
20 checks passed
@jansiegel jansiegel deleted the feature/extendBaseEditorTypes branch August 8, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@budnix budnix budnix approved these changes

Assignees

@jansiegel jansiegel

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jansiegel @AMBudnik @budnix