Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Broken Typescript Types #10509

Closed
jd-carroll opened this issue Sep 12, 2023 · 5 comments
Closed

[Bug]: Broken Typescript Types #10509

jd-carroll opened this issue Sep 12, 2023 · 5 comments

Comments

@jd-carroll
Copy link

Describe the bug

Handsontable does not export types for esModules (i.e. package.json exports). In almost all locations within Handsontable packages, the exports are structured like:

  // node_modules/handsontable/package.json
  ...
  exports: {
    ...
    "./base": {
      "import": "./base.mjs",
      "require": "./base.js"
    },
  ...

When it should be:

  // node_modules/handsontable/package.json
  ...
  exports: {
    ...
    "./base": {
      "types": "./base.d.ts",
      "import": "./base.mjs",
      "require": "./base.js"
    },
  ...

To reproduce follow these steps:

  1. npx create-next-app@latest (make sure to keep typescript enabled)
  2. npm install handsontable@latest @handsontable/react@latest
  3. Open ./src/app/page.tsx
  4. Attempt to install the react demo:
<HotTable
  data={[
    ['', 'Tesla', 'Volvo', 'Toyota', 'Ford'],
    ['2019', 10, 11, 12, 13],
    ['2020', 20, 11, 14, 13],
    ['2021', 30, 15, 12, 13]
  ]}
  rowHeaders={true}
  colHeaders={true}
  height="auto"
  licenseKey="non-commercial-and-evaluation" // for non-commercial use only
/>

Video/Screenshots

No response

Provide a link to the demo with the bug reproduction

No response

Handsontable version

@latest

Framework version

No response

Your environment

Chrome MacOS

@jd-carroll jd-carroll added the bug label Sep 12, 2023
@jd-carroll
Copy link
Author

No easy way to say this, but this issue combined with #7445 make Handsontable an absolute non-starter.

I want to be a customer, this is the right grid framework for us. But add in #9397 and there is just no way we can justify the time investment for Handsontable. The decision for us is now between a competitor or rolling our own (most likely a competitor).

Hope these issues can be resolved in the near future, because again, Handsontable is the right grid framework for our use cases.

Thank you!

@adrianszymanski89
Copy link
Contributor

Hi @jd-carroll

Thank you for reporting this. I understand your arguments, and as I mentioned at #9397 - this will be worked on in the near future. As for #7445, it needs further investigation, and we don't have any specific timeline for this. The fastest issue to solve would be this one. I'll report it internally.

@myessail
Copy link

@adrianszymanski89 is there a timeline for this issue, #10509, as well? this is causing a lot of headaches for our team as well.

@adrianszymanski89
Copy link
Contributor

Hi @myessail

Not yet. We have a full backlog at the moment, but as soon as it gets to our roadmap, I'll let you know.

@evanSe evanSe mentioned this issue Oct 22, 2023
12 tasks
@AMBudnik
Copy link
Contributor

AMBudnik commented Dec 1, 2023

Hi @jd-carroll @myessail, please feel free to update to Handsontable v14.0.0 where this issue is solved.

Here https://handsontable.com/docs/javascript-data-grid/release-notes/#_14-0-0 is a full list of changes and fixes for this version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants