Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Typescript definition of method clearBorders of custom borders plugin asks for an argument #10515

Closed
seleckis opened this issue Sep 19, 2023 · 2 comments · Fixed by #10659

Comments

@seleckis
Copy link

Describe the bug

By documentation clearBorders could be used without argument, but the interface of CustomBorders class is the following:

export class CustomBorders extends BasePlugin {
  constructor(hotInstance: Core);
  isEnabled(): boolean;
  setBorders(selectionRanges: RangeType[][] | Array<[number, number, number, number]>, borderObject: object): void;
  getBorders(selectionRanges: RangeType[][] | Array<[number, number, number, number]>): Array<[object]>;
  clearBorders(selectionRanges: RangeType[][] | Array<[number, number, number, number]>): void;
}

export class CustomBorders extends BasePlugin {

seems like should be:

...
  clearBorders(selectionRanges?: RangeType[][] | Array<[number, number, number, number]>): void;
...

Video/Screenshots

Screenshot 2023-09-19 at 14 32 34

Provide a link to the demo with the bug reproduction

No response

Handsontable version

13.1.0

Framework version

Next.js 13.4.12

Your environment

MacOS Ventura 13.5.2

@seleckis seleckis added the bug label Sep 19, 2023
@adrianszymanski89
Copy link
Contributor

Hi @seleckis

Thank you for reporting this. I'll report it internally for further discussion and get back to you once we have the possible timeline for the fix.

@AMBudnik
Copy link
Contributor

Hi @seleckis

We just released Handsontable v14.1.0, where this issue is fixed.

If you would like to read more about the changes and fixed for this version please feel free to take a look at our recent blog post at https://handsontable.com/blog/handsontable-14-1-0-typescript-ssr-improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants