Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve TS typings for the CustomBorders plugin #10659

Merged
merged 5 commits into from Dec 15, 2023
Merged

Improve TS typings for the CustomBorders plugin #10659

merged 5 commits into from Dec 15, 2023

Conversation

budnix
Copy link
Member

@budnix budnix commented Dec 14, 2023

Context

The PR improves TS typings for the CustomBorders plugin.

How has this been tested?

I tested the changes locally and I covered the fix with new tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Related issue(s):

  1. fixes [Bug]: Typescript definition of method clearBorders of custom borders plugin asks for an argument #10515

Affected project(s):

  • handsontable

Checklist:

@budnix budnix self-assigned this Dec 14, 2023
@budnix budnix marked this pull request as ready for review December 14, 2023 09:19
@budnix budnix merged commit c450850 into develop Dec 15, 2023
21 checks passed
@budnix budnix deleted the feature/issue-10515 branch December 15, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wszymanski wszymanski wszymanski approved these changes

Assignees

@budnix budnix

Labels
Status: Released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Typescript definition of method clearBorders of custom borders plugin asks for an argument
3 participants
@budnix @wszymanski @AMBudnik