-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
beforeKeyDown -> event.stopImmediatePropagation() doesn't work #2207
Comments
found a workaround for this by calling: instead of ev.stopImmediatePropagation(); |
You could also add |
I assume it not an issue anymore (in lack of recent activity and any other questions.) |
You assume wrong. At least the documentation should be fixed. It advocates ev.stopImmediatePropagation() in places. |
Ok thanks @FeepingCreature for your suggestion. |
Extend native method `event.stopImmediatePropagation()` to stop event propagation in Handsontable event manager.
I'm transferring all the improvement suggestion to our Wiki section at: improvement suggestions Please feel free to add any additional suggestions/tips or investigation results. Issue is closed. It will be reopened with a developing update. |
At the moment im working in angular with handsonetable and i cant make it work.. the version is 2.0.0. It is a very crucial functionality which I need. Can you please help me out with it? |
Can I ask you to create a demo @arfis ? |
i have created an demo on git.. https://github.com/arfis/angularTest. The TableComponent contains the table. |
When I wanted to clone the repository I got an error and a note that I do not have a permission to do this. |
I have written you a mail |
For those who may come across this having issues with this via Angular and accessing KeyboardEvent with the beforeKeyDown hook, here's are your options to being able to use preventDefault / stopImmediatePropagation as noted in the docs:
|
To updated the subject I've just check v8.4.0 on
and it works well in all of the cases with a simple implementation of beforeKeyDown: function(ev) {
ev.stopImmediatePropagation();
} |
I've tried the latest 0.12.6 version and noticed:
beforeKeyDown:function(ev){
ev.stopImmediatePropagation();
}
doesn't work anymore..
try: http://jsfiddle.net/0bg3cLjy and notice you can make changes in the editor by pressing keydown
The text was updated successfully, but these errors were encountered: