Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't edit column for field named "length" #3145

Closed
arosequist opened this issue Jan 21, 2016 · 4 comments
Closed

Can't edit column for field named "length" #3145

arosequist opened this issue Jan 21, 2016 · 4 comments
Assignees
@budnix
Labels
bug Core: Handsontable Plugin Guess: A few hours Status: Released
Milestone
0.24.2

Comments

@arosequist
Copy link

If you bind a column to a field named length and try to edit it, it fails with: Uncaught TypeError: Cannot assign to read only property 'row' of 9

Example: http://jsfiddle.net/qaL1yczr/13/
@AMBudnik
Copy link
Contributor

Confirmed, this name can't be used.

@budnix
Copy link
Member

budnix commented Jan 22, 2016

This is a bug. All property names and methods which exist in Array.prototype for now are buggy (eq. length, map, filter etc.). In this case length has the most side effects.

@krzysztofspilka krzysztofspilka added this to the 0.23.2 milestone Feb 19, 2016
@krzysztofspilka krzysztofspilka modified the milestones: 0.24.1, 0.24.2 Mar 16, 2016
@budnix budnix self-assigned this Mar 22, 2016
budnix added a commit that referenced this issue Mar 22, 2016
@budnix
Fix dropdown validation hook where propToCol translation was missing. #…
791872d 
…3145
@budnix budnix assigned jansiegel and unassigned budnix Mar 22, 2016
@jansiegel jansiegel assigned budnix and unassigned jansiegel Apr 6, 2016
@krzysztofspilka
Copy link
Member

@jansiegel couldn't test. Could you confirm it is now fixed and apply a 'tested' label to this issue? Thanks!

@krzysztofspilka
Copy link
Member

@arosequist finally released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@budnix budnix

Labels
bug Core: Handsontable Plugin Guess: A few hours Status: Released
Projects
None yet
Milestone
0.24.2
Development

No branches or pull requests
5 participants
@budnix @arosequist @jansiegel @krzysztofspilka @AMBudnik