Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Too much listeners for checkbox renderer #3211

Closed
budnix opened this issue Feb 10, 2016 · 2 comments
Closed

Too much listeners for checkbox renderer #3211

budnix opened this issue Feb 10, 2016 · 2 comments
Assignees
@jansiegel
Labels
Cell type: Checkbox enhancement Guess: 2 hours Status: Released
Milestone
0.24.2

Comments

@budnix
Copy link
Member

budnix commented Feb 10, 2016

Currently checkbox renderer adds listener to input element for every cell. Additionally every new listener is added with every table render which drastically increase number of listeners. This behavior unnecessary increase memory usage and extends Handsontable destructing.

Needs to implement event delegation.
@budnix budnix added this to the 0.22.1 milestone Feb 10, 2016
@krzysztofspilka krzysztofspilka modified the milestones: 0.23.0, 0.23.1 Feb 19, 2016
@krzysztofspilka krzysztofspilka modified the milestones: 0.24.0, 0.24.1, 0.24.2 Mar 15, 2016
@jansiegel jansiegel self-assigned this Mar 29, 2016
jansiegel added a commit that referenced this issue Mar 30, 2016
@jansiegel
Add event delegation to the checkbox renderer. #3211
62158fd
@jansiegel jansiegel assigned budnix and unassigned jansiegel Mar 30, 2016
@budnix budnix assigned jansiegel and unassigned budnix Apr 4, 2016
@krzysztofspilka
Copy link
Member

@budnix couldn't test it, can you confirm the 'tested' status? If so, add a correct label.

@budnix
Copy link
Member Author

budnix commented Apr 8, 2016

Yes, I confirm it. Works as expected.

@AMBudnik AMBudnik mentioned this issue May 19, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
Cell type: Checkbox enhancement Guess: 2 hours Status: Released
Projects
None yet
Milestone
0.24.2
Development

No branches or pull requests
3 participants
@budnix @jansiegel @krzysztofspilka