Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.31.0+] Disabling the colHeaders property using updateSettings doesn't work. #4136

Closed
jansiegel opened this issue Mar 15, 2017 · 3 comments
Closed

[0.31.0+] Disabling the colHeaders property using updateSettings doesn't work. #4136

jansiegel opened this issue Mar 15, 2017 · 3 comments
Assignees
@mrpiotr-dev
Labels
bug Core: Update settings Plugin Headers Regression Issues that were created while adding new changes to the source code Status: Released
Milestone
January 2019

Comments

@jansiegel
Copy link
Member

jansiegel commented Mar 15, 2017 •
edited
Loading

Description

When trying to disable the colHeaders property by using the updateSettings method, the column headers don't get removed. Instead, we're left with a non-functional, not scrollable header bar at the top of the table, covering the first data row.

Seems to happen since 0.31.0

Steps to reproduce

  1. Go to http://jsfiddle.net/js_ziggle/ukkk3c1L/
  2. Scroll the table to see, that the column headers are broken

Your environment

  • Handsontable version: 0.31.1
  • Browser Name and version: Chrome 56.0.2924.87
  • Operating System: OSX El Capitan
@mrpiotr-dev
Copy link
Contributor

I think header management doesn't work properly since 0.29.0: http://jsfiddle.net/k2gdhdcy/

@AMBudnik AMBudnik mentioned this issue Aug 28, 2017
Closed
@AMBudnik
Copy link
Contributor

The issue is replicable in v0.35.0 as well

@AMBudnik AMBudnik added the Regression Issues that were created while adding new changes to the source code label Aug 28, 2018
@AMBudnik
Copy link
Contributor

v0.30.1 disabled the headers completely.

from v0.31.0 headers are buggy
31

from v2.0.0 to present (v5.0.1) - Headers are partially gone
2

@AMBudnik AMBudnik changed the title Disabling the colHeaders property using updateSettings doesn't work. [0.31.0+] Disabling the colHeaders property using updateSettings doesn't work. Aug 28, 2018
@mrpiotr-dev mrpiotr-dev self-assigned this Jan 4, 2019
@mrpiotr-dev mrpiotr-dev added this to the January 2019 milestone Jan 4, 2019
mrpiotr-dev added a commit that referenced this issue Jan 5, 2019
@mrpiotr-dev
Fixed: headers behaviour after disabling them in updateSettings. #4136
85c2db4
@mrpiotr-dev mrpiotr-dev mentioned this issue Jan 7, 2019
Merged
1 task
mrpiotr-dev added a commit that referenced this issue Jan 7, 2019
@mrpiotr-dev
Removed unnecessary comments. #4136
216818a
mrpiotr-dev pushed a commit that referenced this issue Jan 17, 2019
@swistach
Should be able to disable colHeaders using updateSettings. (#5705)
d944e23 
* Fixed: headers behaviour after disabling them in updateSettings. #4136

* Removed unnecessary comments. #4136
@jansiegel jansiegel mentioned this issue Feb 21, 2019
Closed
jansiegel added a commit that referenced this issue Feb 22, 2019
@jansiegel
Partially revert changes from #4136. (#5807)
339617a
@jansiegel jansiegel mentioned this issue Feb 22, 2019
Merged
jansiegel added a commit that referenced this issue Feb 22, 2019
@jansiegel
Partially revert changes from #4136. (#5807) (#5809)
37da8e7 
* Partially revert changes from #4136. (#5807)

* Add a test case for #5807.

* Increase sleep time for the test case. #5807

* Add headers to the test case #5807

* Change data for the test case #5807

* Modify the test case. #5807

* Apply suggestions from code review

Co-Authored-By: jansiegel <jansiegel@users.noreply.github.com>
@AMBudnik AMBudnik closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
bug Core: Update settings Plugin Headers Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
January 2019
Development

No branches or pull requests
3 participants
@jansiegel @AMBudnik @mrpiotr-dev