Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.31.0+] Disabling the `colHeaders` property using `updateSettings` doesn't work. #4136

Closed
jansiegel opened this Issue Mar 15, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@jansiegel
Copy link
Member

jansiegel commented Mar 15, 2017

Description

When trying to disable the colHeaders property by using the updateSettings method, the column headers don't get removed. Instead, we're left with a non-functional, not scrollable header bar at the top of the table, covering the first data row.

Seems to happen since 0.31.0

Steps to reproduce

  1. Go to http://jsfiddle.net/js_ziggle/ukkk3c1L/
  2. Scroll the table to see, that the column headers are broken

Your environment

  • Handsontable version: 0.31.1
  • Browser Name and version: Chrome 56.0.2924.87
  • Operating System: OSX El Capitan
@swistach

This comment has been minimized.

Copy link
Member

swistach commented Jul 13, 2017

I think header management doesn't work properly since 0.29.0: http://jsfiddle.net/k2gdhdcy/

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Jan 22, 2018

The issue is replicable in v0.35.0 as well

@AMBudnik AMBudnik added the Regression label Aug 28, 2018

@AMBudnik

This comment has been minimized.

Copy link
Contributor

AMBudnik commented Aug 28, 2018

v0.30.1 disabled the headers completely.

from v0.31.0 headers are buggy
31

from v2.0.0 to present (v5.0.1) - Headers are partially gone
2

@AMBudnik AMBudnik changed the title Disabling the `colHeaders` property using `updateSettings` doesn't work. [0.31.0+] Disabling the `colHeaders` property using `updateSettings` doesn't work. Aug 28, 2018

@swistach swistach self-assigned this Jan 4, 2019

@swistach swistach added this to the January 2019 milestone Jan 4, 2019

swistach added a commit that referenced this issue Jan 5, 2019

swistach added a commit that referenced this issue Jan 7, 2019

swistach added a commit that referenced this issue Jan 17, 2019

Should be able to disable colHeaders using updateSettings. (#5705)
* Fixed: headers behaviour after disabling them in updateSettings. #4136

* Removed unnecessary comments. #4136

jansiegel added a commit that referenced this issue Feb 22, 2019

jansiegel added a commit that referenced this issue Feb 22, 2019

Partially revert changes from #4136. (#5807) (#5809)
* Partially revert changes from #4136. (#5807)

* Add a test case for #5807.

* Increase sleep time for the test case. #5807

* Add headers to the test case #5807

* Change data for the test case #5807

* Modify the test case. #5807

* Apply suggestions from code review

Co-Authored-By: jansiegel <jansiegel@users.noreply.github.com>

@AMBudnik AMBudnik closed this Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.