Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

afterRowMove hook returns improper target parameter #4377

Closed
AMBudnik opened this issue Jul 7, 2017 · 4 comments
Closed

afterRowMove hook returns improper target parameter #4377

AMBudnik opened this issue Jul 7, 2017 · 4 comments
Assignees
@wszymanski
Labels
bug Core: Callbacks Plugin Moving Status: Released
Milestone
0.34.1

Comments

@AMBudnik
Copy link
Contributor

AMBudnik commented Jul 7, 2017 •
edited by wszymanski

Description

The target parameter doesn't return a valid index

Steps to reproduce (target values)

  1. Drag any row below the table.

Demo

moving rows

http://jsfiddle.net/rzs1Lcom

Your environment

  • Handsontable version: 0.32.0
  • Browser Name and version: Chrome 59
  • Operating System: Windows 10

[Gr #7220, forum #1192, Gr #7188, Gr #7535]
@wszymanski wszymanski self-assigned this Jul 31, 2017
wszymanski added a commit that referenced this issue Aug 2, 2017
@wszymanski
Removed lines affecting to bad calculation of target when dragged bel…
e54422c 
…ow the table #4377
wszymanski added a commit that referenced this issue Aug 2, 2017
@wszymanski
Reverted formatting #4377
a1fac9e
wszymanski added a commit that referenced this issue Aug 2, 2017
@wszymanski
Changed test to check if hook was triggered with visual indexes as pa…
3bc5135 
…rameters #4377
wszymanski added a commit that referenced this issue Aug 2, 2017
@wszymanski
Added & changed test #4377
d0aeac3
wszymanski added a commit that referenced this issue Aug 2, 2017
@wszymanski
Extra test #4377
023a8a1
@wszymanski
Copy link
Contributor

wszymanski commented Aug 2, 2017 •
edited

I divide this problem into two smaller. I change ticket name and description.

@wszymanski wszymanski changed the title afterRowMove hook returns false data afterRowMove hook returns improper target parameter Aug 2, 2017
@wszymanski
Copy link
Contributor

wszymanski commented Aug 2, 2017 •
edited

The second part of original ticket will be fixed within #4444.

@wszymanski wszymanski mentioned this issue Aug 2, 2017
Closed
@wszymanski wszymanski assigned mrpiotr-dev and unassigned wszymanski Aug 2, 2017
@wszymanski wszymanski added this to the 0.35.0 milestone Aug 31, 2017
@krzysztofspilka
Copy link
Member

krzysztofspilka commented Sep 6, 2017 •
edited

@wszymanski Failed test results (based on visual indices on the front-end and values printed in the web console in result):

  1. Move 3 before 1 => index 0 (Correct)
  2. Move 3 before 2 => index 1 (Correct)
  3. Move 2 after 3 => index 3 (Wrong)

screen shot 2017-09-06 at 11 49 27

Demo: http://jsfiddle.net/rzs1Lcom
Version: 1.13.1, localhost

@wszymanski wszymanski mentioned this issue Sep 6, 2017
Closed
@wszymanski
Copy link
Contributor

wszymanski commented Sep 6, 2017 •
edited

Seems that moving rows from top to bottom don't work. Will be fixed within #4501 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wszymanski wszymanski

Labels
bug Core: Callbacks Plugin Moving Status: Released
Projects
None yet
Milestone
0.34.1
Development

No branches or pull requests
5 participants
@wszymanski @jansiegel @krzysztofspilka @AMBudnik @mrpiotr-dev