Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.37.0+] Cell selection is not calculated properly if merged cells are in selection. #4912

Closed
mrpiotr-dev opened this issue Mar 7, 2018 · 2 comments
Closed

[0.37.0+] Cell selection is not calculated properly if merged cells are in selection. #4912

mrpiotr-dev opened this issue Mar 7, 2018 · 2 comments
Assignees
@mrpiotr-dev
Labels
bug Merge cells Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Milestone
January 2019

Comments

@mrpiotr-dev
Copy link
Contributor

Description

As you can see below. If you try to select merged cells and single cells from last column/row, then the selection is calculated improperly.

merge_selection

Steps to reproduce

  1. Try to select A1:H4
    Expected: Selected A1:H6
    Result: selected A1:H4

Demo

https://jsfiddle.net/yxudqx9w/

Your environment

  • Handsontable version: 0.37.0
  • Browser Name and version: any
  • Operating System: any
@AMBudnik
Copy link
Contributor

It has changed a little bit in v 2.0.0, and yes the 0.37.0 was the first verion to produce this bug.

image

@AMBudnik AMBudnik added the Regression Issues that were created while adding new changes to the source code label Apr 27, 2018
@AMBudnik AMBudnik changed the title Cell selection is not calculated properly if merged cells are in selection. [0.37.0+] Cell selection is not calculated properly if merged cells are in selection. Apr 27, 2018
@AMBudnik
Copy link
Contributor

AMBudnik commented Sep 6, 2018

It works the same in v 5.0.1

mrpiotr-dev added a commit that referenced this issue Jan 7, 2019
@mrpiotr-dev
Fixed: selection of the merged cells. #4912
58133c3
@mrpiotr-dev mrpiotr-dev mentioned this issue Jan 7, 2019
Merged
3 tasks
@mrpiotr-dev mrpiotr-dev added this to the January 2019 milestone Jan 7, 2019
@mrpiotr-dev mrpiotr-dev self-assigned this Jan 7, 2019
mrpiotr-dev pushed a commit that referenced this issue Jan 25, 2019
@swistach
Fixed: selection of the merged cells. #4912 (#5706)
c53ab16
@AMBudnik AMBudnik closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrpiotr-dev mrpiotr-dev

Labels
bug Merge cells Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Milestone
January 2019
Development

No branches or pull requests
2 participants
@AMBudnik @mrpiotr-dev