Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merging object cells in a horizontal direction doesn't work #5022

Closed
krzysztofspilka opened this issue Apr 11, 2018 · 1 comment
Closed

Merging object cells in a horizontal direction doesn't work #5022

krzysztofspilka opened this issue Apr 11, 2018 · 1 comment
Assignees
@jansiegel
Labels
Auto fill Plugin bug Merge cells Plugin Status: Released
Milestone
December 2018

Comments

@krzysztofspilka
Copy link
Member

krzysztofspilka commented Apr 11, 2018 •
edited
Loading

Description

Merge cells doesn't work when using an autofill option in a horizontal direction. Apparently, this bug occurs only at handsontable.com/examples

Steps to reproduce

  1. Go to https://handsontable.com/examples
  2. Merge two cells in the column "Currency"
  3. Use a fill handle to populate merged cells to the right

Demo

https://handsontable.com/examples?manual-resize&manual-move&conditional-formatting&context-menu&filters&dropdown-menu&headers

kapture 2018-04-11 at 15 55 15

Your environment

  • Handsontable version: 2.0.0
  • Browser Name and version: Chrome 65.0
  • Operating System: macOS
@krzysztofspilka krzysztofspilka added this to the Backlog milestone Apr 11, 2018
@AMBudnik AMBudnik changed the title Merging cells in a horizontal direction doesn't work Merging object cells in a horizontal direction doesn't work Apr 20, 2018
@AMBudnik
Copy link
Contributor

It looks like the behavior is caused by object data source. Here https://jsfiddle.net/qw6catpc/we can test (on minimal settings) that when we pass as array the merging is passed via autofill.

array

And here is an object: https://jsfiddle.net/g3cnuzm6/

object

It doesn't seem to work fine in any of the previous versions. Tested with latest 2.0.0. and versions as old as 0.15.0

@wojciechczerniak wojciechczerniak removed this from the Backlog milestone Sep 11, 2018
@jansiegel jansiegel self-assigned this Nov 30, 2018
@jansiegel jansiegel added this to the December 2018 milestone Nov 30, 2018
jansiegel added a commit that referenced this issue Dec 4, 2018
@jansiegel
Fix improper range generation for mergeCells' autofill. #5022
6d815d3
@jansiegel jansiegel mentioned this issue Dec 4, 2018
Merged
1 task
jansiegel added a commit that referenced this issue Dec 5, 2018
@jansiegel
Post-CR changes. #5022
a2a318b
jansiegel added a commit that referenced this issue Dec 5, 2018
@jansiegel
Fix autofill for mergeCells with data declared as an array of objects. (
0166d4d 
#5634)

* Fix improper range generation for mergeCells' autofill. #5022

* Post-CR changes. #5022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jansiegel jansiegel

Labels
Auto fill Plugin bug Merge cells Plugin Status: Released
Projects
None yet
Milestone
December 2018
Development

No branches or pull requests
4 participants
@wojciechczerniak @jansiegel @krzysztofspilka @AMBudnik