Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type definition renderer #5091

Closed
oleksandr-dakal opened this issue May 9, 2018 · 3 comments
Closed

Type definition renderer #5091

oleksandr-dakal opened this issue May 9, 2018 · 3 comments
Labels
bug Status: Released TypeScript

Comments

@oleksandr-dakal
Copy link

Description

Type definition not correct for interface Handsontable.renderer.Base. cellProperties defined as GridSettings that is not correct and break typing when try to use renderer from cellProperties.

Your environment
Handsontable version: 2.0.0
Browser Name and version: Chrome 65.0.3325.181
Operating System: Windows 10
@AMBudnik
Copy link
Contributor

Thank you @oleksandr-dakal

we'll check that

@AMBudnik AMBudnik mentioned this issue May 10, 2018
Closed
@aaronbeall
Copy link
Contributor

@oleksandr-dakal What exactly is wrong about the type definition?

@aaronbeall aaronbeall mentioned this issue Feb 6, 2019
Merged
6 tasks
@wojciechczerniak wojciechczerniak mentioned this issue Feb 14, 2019
Closed
23 tasks
@AMBudnik
Copy link
Contributor

AMBudnik commented Mar 6, 2019

Hey @oleksandr-dakal

We've updated the Handsontable to v 7.0.0 were we've added all the changed proposed by Aaron #5767

@AMBudnik AMBudnik closed this as completed Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Status: Released TypeScript
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@aaronbeall @oleksandr-dakal @AMBudnik