Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type definition renderer #5091

Closed
oleksandr-dakal opened this Issue May 9, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@oleksandr-dakal
Copy link

commented May 9, 2018

Description

Type definition not correct for interface Handsontable.renderer.Base. cellProperties defined as GridSettings that is not correct and break typing when try to use renderer from cellProperties.

Your environment
Handsontable version: 2.0.0
Browser Name and version: Chrome 65.0.3325.181
Operating System: Windows 10

@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented May 10, 2018

Thank you @oleksandr-dakal

we'll check that

@aaronbeall

This comment has been minimized.

Copy link
Contributor

commented Jan 16, 2019

@oleksandr-dakal What exactly is wrong about the type definition?

@aaronbeall aaronbeall referenced this issue Feb 6, 2019

Merged

TypeScript .d.ts type definitions improvement #5767

2 of 6 tasks complete

@wojciechczerniak wojciechczerniak referenced this issue Feb 14, 2019

Open

Refactor Typescript definition files #5094

19 of 23 tasks complete
@AMBudnik

This comment has been minimized.

Copy link
Contributor

commented Mar 6, 2019

Hey @oleksandr-dakal

We've updated the Handsontable to v 7.0.0 were we've added all the changed proposed by Aaron #5767

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.