Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
TypeScript .d.ts type definitions improvement #5767
This is a sweeping refinement of the type definitions. Main goals were:
How has this been tested?
Types of changes
@aaronbeall That's really impressive!
I have one small suggestion, though:
Internally we tend to use the term "events" as native DOM events, and "hooks" as our internal events. That being said, splitting the hook API and hooks themselves, just like you did, is definitely a good idea.
I think it would be good to move the
Other than that everything looks great!
This was referenced
Feb 14, 2019
Yep, sounds good. Done! TBH I wanted to keep the event hooks interface as
Edit: Hmm... how about putting