Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.1.0+] Copy/Paste read/write clipboard incorrectly #5544

Closed
cuongurus opened this issue Oct 25, 2018 · 3 comments
Closed

[6.1.0+] Copy/Paste read/write clipboard incorrectly #5544

cuongurus opened this issue Oct 25, 2018 · 3 comments
Assignees
Labels
bug Copy-paste Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Milestone

Comments

@cuongurus
Copy link

Description

Copy a cell with value == 0, NaN or null then paste empty to other cell or excel.
I believe function arrayToTable(input) with below lines of code cause to this issue:

    for (var column = 0; column < columnsLen; column += 1) {
      tempElement.innerText = '' + (rowData[column] || '');

      columnsResult.push('<td>' + tempElement.innerHTML + '</td>');
    }

Your environment

  • Handsontable version: 6.1.0+
  • Browser Name and version: Chrome 70
  • Operating System: Windows 10
@wojciechczerniak
Copy link
Contributor

@cuongurus You're right, 0 is a valid value. But is there a use case for NaN and null that you are mentioning them?

@cuongurus
Copy link
Author

@wojciechczerniak, hard to describe my use case but fix value == 0 is enough. I will use string "NaN" instead. Thanks!

@AMBudnik AMBudnik added Copy-paste Plugin Regression Issues that were created while adding new changes to the source code labels Oct 29, 2018
@pnowak pnowak assigned pnowak and unassigned jansiegel Oct 29, 2018
pnowak added a commit that referenced this issue Oct 29, 2018
pnowak added a commit that referenced this issue Nov 5, 2018
pnowak pushed a commit that referenced this issue Nov 6, 2018
after CR: should copy 0 and false #5544
@AMBudnik
Copy link
Contributor

Welcome @cuongurus

I am more than happy to say that the fix is published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Copy-paste Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

No branches or pull requests

5 participants