Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.0.0+] Error after updating data when using columnSorting #5617

Closed
swk777 opened this issue Nov 27, 2018 · 6 comments
Closed

[6.0.0+] Error after updating data when using columnSorting #5617

swk777 opened this issue Nov 27, 2018 · 6 comments
Assignees
Labels
bug Column sorting Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Milestone

Comments

@swk777
Copy link

swk777 commented Nov 27, 2018

Description

I m having issues when I try to update data using updateSettings.It's linked to the plugin columnSorting.

Steps to reproduce

1.create a table using plugin columnSorting.
2. update data using updateSettings.
3.check the console.

Demo

https://jsfiddle.net/swk777/mz4tpuk2/3/

Your environment

  • Handsontable version:6.2.0
  • Browser Name and version:all
  • Operating System:all
@AMBudnik
Copy link
Contributor

Hey @swk777

it looks like the line 18 is an issue.

@swk777
Copy link
Author

swk777 commented Nov 27, 2018

Hey @swk777

it looks like the line 18 is an issue.

Sorry I didn't get your point.It occurs every time when I update the data after the table is rendered,setTimeout is just a simulation.

@AMBudnik
Copy link
Contributor

AMBudnik commented Nov 27, 2018

Sorry @swk777

I was doing the investigation and posted a comment without any clue.

The columnSorting is looking for an indicator of a column that is not yet rendered. (to be confirmed)
The log is also returned when we use loadData without updateSettings method. This is a serious issue, as columnSorting is one of our main features.

It looks like the version 6.0.0 broke this functionality as it works fine in 5.0.2 https://jsfiddle.net/fb7dacry/

Thank you very much for sharing

@AMBudnik AMBudnik added bug Column sorting Plugin Regression Issues that were created while adding new changes to the source code labels Nov 27, 2018
@AMBudnik AMBudnik changed the title Error after updating data when using columnSorting [6.0.0+] Error after updating data when using columnSorting Nov 27, 2018
@AMBudnik
Copy link
Contributor

Updated and simplified example

When we want to load more columns then we had before we get the issue (load at least two more columns)

https://jsfiddle.net/3paz14v6/

@wojciechczerniak wojciechczerniak added this to the December 2018 milestone Nov 27, 2018
@jansiegel jansiegel self-assigned this Nov 27, 2018
jansiegel added a commit that referenced this issue Dec 3, 2018
jansiegel added a commit that referenced this issue Dec 5, 2018
* Clear the column meta cache after loading new data. #5617

* - Modify the column meta cache generation to prevent unneeded entries
- Add a test case
 #5617

* Prevent the 'autoColumnSize' and 'autoRowSize' calculations if there are not enought columns/rows in the dataset. #5617
@AMBudnik
Copy link
Contributor

Hey @swk777

we've just released v6.2.1 where this issue is fixed :)

@swk777
Copy link
Author

swk777 commented Dec 13, 2018

Hey @swk777

we've just released v6.2.1 where this issue is fixed :)

cheers:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Column sorting Plugin Regression Issues that were created while adding new changes to the source code Status: Released
Projects
None yet
Development

No branches or pull requests

4 participants